Merge lp://staging/~roadmr/django-saml2-idp/pass-proper-signing-parameter into lp://staging/~ubuntuone-pqm-team/django-saml2-idp/stable
Proposed by
Daniel Manrique
| Status: | Merged |
|---|---|
| Approved by: | Daniel Manrique |
| Approved revision: | 77 |
| Merged at revision: | 76 |
| Proposed branch: | lp://staging/~roadmr/django-saml2-idp/pass-proper-signing-parameter |
| Merge into: | lp://staging/~ubuntuone-pqm-team/django-saml2-idp/stable |
| Diff against target: |
50 lines (+5/-5) 2 files modified
idptest/saml2idp/xml_render.py (+4/-4) setup.py (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~roadmr/django-saml2-idp/pass-proper-signing-parameter |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Maximiliano Bertacchini | Approve | ||
|
Review via email:
|
|||
Commit message
use the signing_algorithm value passed to a method instead of clobbering it with None.
Description of the change
Without this, some parts of the assertion where signed/digested using sha1 and others using the specified algorithm, which makes some SAML consumers understandably sad :(
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
+1