Merge lp://staging/~roadmr/django-saml2-idp/multi-value-attribute into lp://staging/~ubuntuone-pqm-team/django-saml2-idp/stable

Proposed by Daniel Manrique
Status: Merged
Approved by: Daniel Manrique
Approved revision: 79
Merged at revision: 78
Proposed branch: lp://staging/~roadmr/django-saml2-idp/multi-value-attribute
Merge into: lp://staging/~ubuntuone-pqm-team/django-saml2-idp/stable
Diff against target: 104 lines (+59/-5)
3 files modified
idptest/saml2idp/tests/signing.py (+32/-0)
idptest/saml2idp/xml_render.py (+21/-3)
idptest/saml2idp/xml_templates.py (+6/-2)
To merge this branch: bzr merge lp://staging/~roadmr/django-saml2-idp/multi-value-attribute
Reviewer Review Type Date Requested Status
Matias Bordese (community) Approve
Review via email: mp+404477@code.staging.launchpad.net

Commit message

Add support for multi-value attributes (lists).

If the value for an attribute is a list, Render it with an AttributeValue per list element.

Example, if the value for the "support-emails" attribute is

["<email address hidden>", "<email address hidden>"]

The xml looks like this:

<saml:Attribute Name="support-emails">
    <saml:AttributeValue><email address hidden></saml:AttributeValue>
    <saml:AttributeValue><email address hidden></saml:AttributeValue>
</saml:Attribute>

To post a comment you must log in.
Revision history for this message
Matias Bordese (matiasb) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches