Merge lp://staging/~roadmr/django-saml2-idp/beyond-sha1-signatures into lp://staging/~ubuntuone-pqm-team/django-saml2-idp/stable
Proposed by
Daniel Manrique
| Status: | Merged |
|---|---|
| Approved by: | Daniel Manrique |
| Approved revision: | 75 |
| Merged at revision: | 74 |
| Proposed branch: | lp://staging/~roadmr/django-saml2-idp/beyond-sha1-signatures |
| Merge into: | lp://staging/~ubuntuone-pqm-team/django-saml2-idp/stable |
| Diff against target: |
217 lines (+72/-20) 8 files modified
README (+15/-0) idptest/saml2idp/base.py (+3/-2) idptest/saml2idp/tests/signing.py (+14/-0) idptest/saml2idp/xml_render.py (+24/-12) idptest/saml2idp/xml_signing.py (+12/-2) idptest/saml2idp/xml_templates.py (+2/-2) requirements.txt (+1/-1) setup.py (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~roadmr/django-saml2-idp/beyond-sha1-signatures |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Wouter van Bommel (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Add support for non-sha1 signatures.
Any method supported by Pyton's hashlib can be passed as a parameter to
format_response or get_assertion_*_xml and it will be used to produce
signatures and digests.
Typical methods to be used are sha2 algorithms (sha256, sha512) in
replacement of the weak sha1 algorithm.
To post a comment you must log in.
Revision history for this message
| Daniel Manrique (roadmr) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
lgtm just some minor issues