Merge lp://staging/~roadmr/checkbox/fix-lintian-warnings into lp://staging/checkbox
Proposed by
Daniel Manrique
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 1139 | ||||
| Proposed branch: | lp://staging/~roadmr/checkbox/fix-lintian-warnings | ||||
| Merge into: | lp://staging/checkbox | ||||
| Diff against target: |
92 lines (+14/-9) 3 files modified
debian/changelog (+5/-1) debian/control (+8/-8) debian/source/format (+1/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~roadmr/checkbox/fix-lintian-warnings | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Marc Tardif (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Just some updates to the debian control files to take care of an old bug. These are just lintian warnings, things work fine even without these changes, and I'm certainly not an expert in Debian packaging, so feel free to comment on this.
I particularly dislike having e.g. checkbox-gtk with this depends:
checkbox (>= ${source:Version})
as it can potentially couple, say, checkbox 0.13 with checkbox-gtk 0.12, but this new format is required for the thing to be "binNMUable" (I'll spare you the trouble of hunting down useful information on that: http://
As I said before, these are all just warnings and can potentially be ignored.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Lintian is pedantic but pedantic is not always right. This applies to debian packaging but Python as well, like this also throws a warning by pylint:
try:
import xml.etree.
except ImportError:
import cElementTree as etree
# redefinition of unused 'etree'
As long as it doesn't hurt (too much), I'm alright with changes like (>= ${source:Version}).