Merge lp://staging/~roadmr/checkbox/921128-898641 into lp://staging/checkbox

Proposed by Daniel Manrique
Status: Merged
Merged at revision: 1207
Proposed branch: lp://staging/~roadmr/checkbox/921128-898641
Merge into: lp://staging/checkbox
Diff against target: 92 lines (+19/-7)
3 files modified
debian/changelog (+3/-1)
debian/control (+1/-1)
jobs/suspend.txt.in (+15/-5)
To merge this branch: bzr merge lp://staging/~roadmr/checkbox/921128-898641
Reviewer Review Type Date Requested Status
Marc Tardif (community) Approve
Daniel Manrique (community) Needs Resubmitting
Review via email: mp+90798@code.staging.launchpad.net

Description of the change

Fixes two bugs:

- Add requirement for BLUETOOTH devices to obex jobs. Not sure if failure of one of these will keep the system from running suspend_advanced.

- Make checkbox explicitly recommend gstreamer0.10-gconf, so that installing checkbox on kubuntu automatically pulls that in, enabling the media tests to run. AFAIK gstreamer0.10-gconf is in the default Ubuntu CD install so it shouldn't imply any changes to plain Ubuntu users.

To post a comment you must log in.
Revision history for this message
Marc Tardif (cr3) wrote :

1. Please add gstreamer0.10-gconf in alphabetical order to the recommends line;
2. Please add the device.category requirement on a separate line from the package.name requirement:

  requires:
   package.name == 'bluez' and package.name == 'obexd-client'
   device.category == 'BLUETOOTH'

review: Needs Fixing
Revision history for this message
Daniel Manrique (roadmr) wrote :

Thanks for the review!

I've applied the suggested fixes, I hope it's all better now!

review: Needs Resubmitting
1209. By Daniel Manrique

Fixed formatting and recommends ordering

Revision history for this message
Marc Tardif (cr3) wrote :

Looks good, merging.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches