Merge lp://staging/~roadmr/checkbox/1259879-fix-virtualization into lp://staging/checkbox

Proposed by Daniel Manrique
Status: Merged
Approved by: Daniel Manrique
Approved revision: 2554
Merged at revision: 2560
Proposed branch: lp://staging/~roadmr/checkbox/1259879-fix-virtualization
Merge into: lp://staging/checkbox
Diff against target: 53 lines (+20/-5)
2 files modified
checkbox-old/debian/changelog (+2/-0)
checkbox-old/scripts/virtualization (+18/-5)
To merge this branch: bzr merge lp://staging/~roadmr/checkbox/1259879-fix-virtualization
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
kaxing (community) Approve
Review via email: mp+198822@code.staging.launchpad.net

Commit message

scripts/virtualization: Shut down the VM properly so as to not damage the disk image; work properly with "second-boot" VM images (LP: #1259879)

Description of the change

scripts/virtualization: Shut down the VM properly so as to not damage the disk image; work properly with "second-boot" VM images (LP: #1259879)

To post a comment you must log in.
Revision history for this message
kaxing (kaxing) wrote :

+1, Tested and it works!
Got this nice message for the next booting:
    Booted successfully (Previously initalized VM)

review: Approve
Revision history for this message
Daniel Manrique (roadmr) wrote :

The attempt to merge lp:~roadmr/checkbox/1259879-fix-virtualization into lp:checkbox failed. Below is the output from the failed tests.

[precise] Bringing VM 'up'
[precise] Unable to 'up' VM!
[precise] stdout: http://paste.ubuntu.com/6566877/
[precise] stderr: http://paste.ubuntu.com/6566878/
[precise] NOTE: unable to execute tests, marked as failed
[precise] Destroying failed VM to reclaim resources
[precise] Forcing shutdown of VM...
[precise] Destroying VM and associated drives...
[quantal] Bringing VM 'up'
[quantal] Unable to 'up' VM!
[quantal] stdout: http://paste.ubuntu.com/6566887/
[quantal] stderr: http://paste.ubuntu.com/6566889/
[quantal] NOTE: unable to execute tests, marked as failed
[quantal] Destroying failed VM to reclaim resources
[quantal] Forcing shutdown of VM...
[quantal] Destroying VM and associated drives...
[raring] Bringing VM 'up'
[raring] Unable to 'up' VM!
[raring] stdout: http://paste.ubuntu.com/6566907/
[raring] stderr: http://paste.ubuntu.com/6566908/
[raring] NOTE: unable to execute tests, marked as failed
[raring] Destroying failed VM to reclaim resources
[raring] Forcing shutdown of VM...
[raring] Destroying VM and associated drives...

Revision history for this message
Daniel Manrique (roadmr) wrote :

Re-approving due to ubuntu-sdk build failures (they're fixed now).

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches