Merge lp://staging/~roadmr/canonical-identity-provider/update-raven into lp://staging/canonical-identity-provider/release

Proposed by Daniel Manrique
Status: Needs review
Proposed branch: lp://staging/~roadmr/canonical-identity-provider/update-raven
Merge into: lp://staging/canonical-identity-provider/release
Diff against target: 12 lines (+1/-1)
1 file modified
requirements.txt (+1/-1)
To merge this branch: bzr merge lp://staging/~roadmr/canonical-identity-provider/update-raven
Reviewer Review Type Date Requested Status
Adam Collard (community) Approve
Review via email: mp+347402@code.staging.launchpad.net

Commit message

Update raven to 6.9.0 for better Django 1.11-ness.

Basically gets rid of Django 2.0 deprecation warnings.

Description of the change

Update raven to 6.9.0 for better Django 1.11-ness.

Basically gets rid of Django 2.0 deprecation warnings.

To post a comment you must log in.
Revision history for this message
Adam Collard (adam-collard) wrote :

Is this still relevant?

Revision history for this message
Daniel Manrique (roadmr) wrote :

Yes; an SSO test run shows this:

/src/canonical-identity-provider/working/env/local/lib/python2.7/site-packages/raven/ contrib/django/client.py:150: RemovedInDjango20Warning: Using user.is_authenticated() and user.is_anonymous() as a method is deprecated. Remove the parentheses to use it as an attribute.
  authenticated = user.is_authenticated()

this MP would fix that warning.

Revision history for this message
Adam Collard (adam-collard) :
review: Approve

Unmerged revisions

1640. By Daniel Manrique

Update raven to 6.9.0 for better Django 1.11-ness

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.