Merge lp://staging/~rmescandon/scopecreator/rss-template-read-settings-from-metadata-take2 into lp://staging/~scopecreator-team/scopecreator/rss-template

Proposed by Roberto Mier Escandon
Status: Merged
Merged at revision: 11
Proposed branch: lp://staging/~rmescandon/scopecreator/rss-template-read-settings-from-metadata-take2
Merge into: lp://staging/~scopecreator-team/scopecreator/rss-template
Prerequisite: lp://staging/~rmescandon/scopecreator/rss-template-keywords-support
Diff against target: 455 lines (+203/-82)
6 files modified
data/rss.canonical_rss.ini.in (+3/-0)
include/scope/query.h (+23/-1)
include/scope/scope.h (+9/-0)
po/rss.pot (+6/-2)
src/scope/query.cpp (+143/-74)
src/scope/scope.cpp (+19/-5)
To merge this branch: bzr merge lp://staging/~rmescandon/scopecreator/rss-template-read-settings-from-metadata-take2
Reviewer Review Type Date Requested Status
Scott Sweeny (community) Approve
Review via email: mp+267443@code.staging.launchpad.net

Commit message

Same features than branch
scopecreator/rss-template-read-settings-from-metadata

but reading scope .ini file directly using QSettings instead of using Scope::metadata

This solution is working well and can be used as alternative to scopecreator/rss-template-read-settings-from-metadata branch. Only one of both should be merged

Description of the change

Same features than branch
scopecreator/rss-template-read-settings-from-metadata

but reading scope .ini file directly using QSettings instead of using Scope::metadata

This solution is working well and can be used as alternative to scopecreator/rss-template-read-settings-from-metadata branch. Only one of both should be merged

To post a comment you must log in.
Revision history for this message
Scott Sweeny (ssweeny) wrote :

I've been running a scope based on this for a few weeks now and it works flawlessly :-)

Merging.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches