Merge lp://staging/~rmescandon/jenkins-launchpad-plugin/prevent-exception-when-no-downstream-project into lp://staging/jenkins-launchpad-plugin
Proposed by
Roberto Mier Escandon
| Status: | Work in progress |
|---|---|
| Proposed branch: | lp://staging/~rmescandon/jenkins-launchpad-plugin/prevent-exception-when-no-downstream-project |
| Merge into: | lp://staging/jenkins-launchpad-plugin |
| Diff against target: |
15 lines (+5/-2) 1 file modified
jlp/jenkinsutils.py (+5/-2) |
| To merge this branch: | bzr merge lp://staging/~rmescandon/jenkins-launchpad-plugin/prevent-exception-when-no-downstream-project |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Joshua Powers (community) | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
I've hit exceptions when using launchpadTrigger with a job that hasn't downstream projects
To post a comment you must log in.
Unmerged revisions
- 133. By Roberto Mier Escandon
-
prevent exception when not set downstreamProjects job data
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks like you and I both have run into this:
https:/
You can either comment on mine or what we can do is if you fix your bare except (e.g. except -> except KeyError) and add a log message and then I can accept yours.