Prometheus2 charm

Merge ~rmescandon/charm-prometheus2/+git/prometheus2-charm:install-psmisc into ~prometheus-charmers/charm-prometheus2:master

  1. Git
  2. lp:~rmescandon/charm-prometheus2/+git/prometheus2-charm
  3. install-psmisc
  4. Merge into master
Proposed by Roberto Mier Escandon
Status: Merged
Approved by: Tom Haddon
Approved revision: 788fbb4aa6ee857ed9a642d7bb3c403d5ebaefc7
Merged at revision: 93c7fa8d3b1a2fd57f77551341260753140d618e
Proposed branch: ~rmescandon/charm-prometheus2/+git/prometheus2-charm:install-psmisc
Merge into: ~prometheus-charmers/charm-prometheus2:master
Diff against target: 12 lines (+4/-0)
1 file modified
layer.yaml (+4/-0)
Reviewer Review Type Date Requested Status
Tom Haddon (community) Approve
Canonical IS Reviewers Pending
Review via email: mp+358759@code.staging.launchpad.net

Commit message

psmisc package is not included in packet.net machines by default and that makes prometheus fail when using killall command:

line 459, in reload_prometheus subprocess.check_call(['killall', '-HUP', 'prometheus'])

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Tom Haddon (mthaddon) wrote :

LGTM, thx

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 93c7fa8d3b1a2fd57f77551341260753140d618e

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches