Merge lp://staging/~ricmm/qtubuntu-media/eos-playback-complete into lp://staging/qtubuntu-media

Proposed by Ricardo Mendoza
Status: Merged
Merged at revision: 31
Proposed branch: lp://staging/~ricmm/qtubuntu-media/eos-playback-complete
Merge into: lp://staging/qtubuntu-media
Prerequisite: lp://staging/~phablet-team/qtubuntu-media/add-media-hub-support
Diff against target: 92 lines (+27/-8)
4 files modified
src/aal/aalmediaplayercontrol.h (+2/-2)
src/aal/aalmediaplayerservice.cpp (+10/-0)
unittests/player.cpp (+14/-6)
unittests/player.h (+1/-0)
To merge this branch: bzr merge lp://staging/~ricmm/qtubuntu-media/eos-playback-complete
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Jim Hodapp Pending
Review via email: mp+214858@code.staging.launchpad.net

Commit message

Wire EOS from media-hub to playbackComplete

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
33. By Ricardo Mendoza

* Dont install playback complete listener if the hub player session is not yet valid.
* Reorganize mock player declarations to prevent corruption in properties.

34. By Ricardo Mendoza

Add relevant comment

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches