QtMir

Merge lp://staging/~ricmm/qtmir/reduce-timeout into lp://staging/qtmir

  1. reduce-timeout
  2. Merge into trunk
Proposed by Ricardo Mendoza
Status: Merged
Approved by: Gerry Boland
Approved revision: 294
Merged at revision: 307
Proposed branch: lp://staging/~ricmm/qtmir/reduce-timeout
Merge into: lp://staging/qtmir
Diff against target: 12 lines (+1/-1)
1 file modified
src/modules/Unity/Application/session.cpp (+1/-1)
To merge this branch: bzr merge lp://staging/~ricmm/qtmir/reduce-timeout
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+244720@code.staging.launchpad.net

Commit message

Reduce suspend timeout to half of the previous value because the long value was too apparent on fast paced apps, like web games of music players; it broke the user experience according to design.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:294
http://jenkins.qa.ubuntu.com/job/qtmir-ci/181/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-amd64-ci/32
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/32
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/32/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/181/rebuild

review: Approve (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) wrote :

I don't have any objection to this, but are we sure that this won't break any apps? And is there documentation referring to the 3 second timer that would need to be changed?

Revision history for this message
Gerry Boland (gerboland) wrote :

LGTM

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Y
 * Did CI run pass? If not, please explain why.
Y

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches