Merge lp://staging/~ricmm/media-hub/multiple-sessions into lp://staging/media-hub
Proposed by
Ricardo Mendoza
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~ricmm/media-hub/multiple-sessions |
| Merge into: | lp://staging/media-hub |
| Prerequisite: | lp://staging/~phablet-team/media-hub/powerd-interface |
| Diff against target: |
365 lines (+78/-36) 10 files modified
src/core/media/engine.h (+3/-0) src/core/media/gstreamer/engine.cpp (+9/-1) src/core/media/gstreamer/engine.h (+7/-1) src/core/media/gstreamer/playbin.h (+9/-21) src/core/media/player_implementation.cpp (+29/-1) src/core/media/player_implementation.h (+2/-0) src/core/media/service_implementation.cpp (+4/-3) src/core/media/service_skeleton.cpp (+5/-0) src/core/media/service_skeleton.h (+1/-0) tests/unit-tests/test-gstreamer-engine.cpp (+9/-9) |
| To merge this branch: | bzr merge lp://staging/~ricmm/media-hub/multiple-sessions |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Needs Fixing | |
| Ubuntu Phablet Team | Pending | ||
|
Review via email:
|
|||
Commit message
Do not process the state change signal in the functor if the parent Player has been destroyed.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Unmerged revisions
- 29. By Ricardo Mendoza
-
Discard connections to the engine state functor if the player has been destroyed.
- 28. By Ricardo Mendoza
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:29
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://