Merge lp://staging/~rick-rickspencer3/quidgets/precise into lp://staging/quidgets
Proposed by
Rick Spencer
| Status: | Merged |
|---|---|
| Merged at revision: | 166 |
| Proposed branch: | lp://staging/~rick-rickspencer3/quidgets/precise |
| Merge into: | lp://staging/quidgets |
| Diff against target: |
4084 lines (+997/-2064) 14 files modified
quickly/widgets/asynch_task_progressbox.py (+0/-310) quickly/widgets/conventions.py (+0/-2) quickly/widgets/couch_grid.py (+0/-458) quickly/widgets/dictionary_grid.py (+32/-32) quickly/widgets/grid_column.py (+54/-59) quickly/widgets/grid_filter.py (+692/-698) quickly/widgets/media_player_box.py (+61/-58) quickly/widgets/press_and_hold_button.py (+45/-8) quickly/widgets/tests/test_asycnh_task_progress_box.py (+0/-51) quickly/widgets/tests/test_couch_grid.py (+0/-284) quickly/widgets/tests/test_dictionary_grid.py (+7/-8) quickly/widgets/text_editor.py (+34/-31) quickly/widgets/url_fetch_progressbox.py (+39/-35) quickly/widgets/web_cam_box.py (+33/-30) |
| To merge this branch: | bzr merge lp://staging/~rick-rickspencer3/quidgets/precise |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Terry (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Migrated quickly widgets to GObeject Introspection, so they will work with new Quickly projects.
Description of the change
1. deleted couchgrid, since DesktopCouch is no longer recommended (there is currently no upgrade path for apps that used CouchGrid in the past)
2. update all other quidgets to use GOI.
3. ensured all tests ran and passed.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Seems fine, but running the tests on the new code gives me several errors like:
Gtk-WARNING **: Cannot connect attribute `text' for cell renderer class `GtkCellRendere
Is that expected? Aside from that, this is approved. So if you fix that or it's innocuous, push away.