Ratings and Reviews server

Merge lp://staging/~ricardokirkner/rnr-server/review-crud-api-with-macaroons into lp://staging/rnr-server

Proposed by Ricardo Kirkner on 2016-05-17

Status:	Merged
Approved by:	Ricardo Kirkner on 2016-05-20
Approved revision:	334
Merged at revision:	318
Proposed branch:	lp://staging/~ricardokirkner/rnr-server/review-crud-api-with-macaroons
Merge into:	lp://staging/rnr-server
Diff against target:	611 lines (+172/-107) 4 files modified src/clickreviews/api/urls.py (+3/-1) src/clickreviews/tests/test_handlers.py (+160/-65) src/reviewsapp/api/urls.py (+2/-3) src/reviewsapp/tests/test_handlers.py (+7/-38)
To merge this branch:	bzr merge lp://staging/~ricardokirkner/rnr-server/review-crud-api-with-macaroons
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Fabián Ezequiel Gallina (community)		2016-05-17	Approve on 2016-05-20
Review via email: mp+294951@code.staging.launchpad.net

add macaroons support for review CRUD apis

Revision history for this message

Fabián Ezequiel Gallina (fgallina) wrote on 2016-05-18:

Looking good, added few comments.

Revision history for this message

Ricardo Kirkner (ricardokirkner) on 2016-05-20:

332. By Ricardo Kirkner on 2016-05-20: use public names for helper methods
333. By Ricardo Kirkner on 2016-05-20: refactor to avoid duplication
334. By Ricardo Kirkner on 2016-05-20: assert changes on db when deleting a review