Merge lp://staging/~ricardokirkner/rnr-server/flags-n-macaroons into lp://staging/rnr-server

Proposed by Ricardo Kirkner
Status: Merged
Approved by: Ricardo Kirkner
Approved revision: 335
Merged at revision: 319
Proposed branch: lp://staging/~ricardokirkner/rnr-server/flags-n-macaroons
Merge into: lp://staging/rnr-server
Prerequisite: lp://staging/~ricardokirkner/rnr-server/review-crud-api-with-macaroons
Diff against target: 148 lines (+60/-13)
2 files modified
src/clickreviews/api/urls.py (+2/-2)
src/clickreviews/tests/test_handlers.py (+58/-11)
To merge this branch: bzr merge lp://staging/~ricardokirkner/rnr-server/flags-n-macaroons
Reviewer Review Type Date Requested Status
Fabián Ezequiel Gallina (community) Approve
Review via email: mp+294956@code.staging.launchpad.net

Commit message

added macaroons support to packages and reviews flags apis

To post a comment you must log in.
Revision history for this message
Fabián Ezequiel Gallina (fgallina) wrote :

Looking good, added comments.

333. By Ricardo Kirkner

Merged review-crud-api-with-macaroons into flags-n-macaroons.

Revision history for this message
Ricardo Kirkner (ricardokirkner) :
334. By Ricardo Kirkner

assert right package/review have been flagged

335. By Ricardo Kirkner

Merged review-crud-api-with-macaroons into flags-n-macaroons.

Revision history for this message
Fabián Ezequiel Gallina (fgallina) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches