Merge lp://staging/~ricardokirkner/isitdeployable/k8s-job-for-schema-migration into lp://staging/isitdeployable
Proposed by
Ricardo Kirkner
| Status: | Merged |
|---|---|
| Approved by: | Ricardo Kirkner |
| Approved revision: | 270 |
| Merge reported by: | Otto Co-Pilot |
| Merged at revision: | not available |
| Proposed branch: | lp://staging/~ricardokirkner/isitdeployable/k8s-job-for-schema-migration |
| Merge into: | lp://staging/isitdeployable |
| Diff against target: |
147 lines (+64/-29) 3 files modified
deployment/Makefile (+23/-1) deployment/config/deployments.yaml.tpl (+0/-28) deployment/config/migrate-db-job.yaml.tpl (+41/-0) |
| To merge this branch: | bzr merge lp://staging/~ricardokirkner/isitdeployable/k8s-job-for-schema-migration |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Guillermo Gonzalez | Approve | ||
|
Review via email:
|
|||
Commit message
use jobs to run db schema migrations before deployments
Description of the change
By using a job instead of an initContainer it's possible to ensure db migrations are run before the deployment is started. This enables us to remove the throttling on the rolling update process thus improving overall deployment time.
To post a comment you must log in.
Revision history for this message
| Otto Co-Pilot (otto-copilot) wrote | # |
Revision history for this message
| Otto Co-Pilot (otto-copilot) wrote | # |
Revision history for this message
| Otto Co-Pilot (otto-copilot) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM