Merge lp://staging/~ricardokirkner/isitdeployable/docker-build-http-proxy-env into lp://staging/isitdeployable

Proposed by Ricardo Kirkner
Status: Merged
Approved by: Ricardo Kirkner
Approved revision: 234
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: lp://staging/~ricardokirkner/isitdeployable/docker-build-http-proxy-env
Merge into: lp://staging/isitdeployable
Diff against target: 11 lines (+1/-1)
1 file modified
Makefile.k8s (+1/-1)
To merge this branch: bzr merge lp://staging/~ricardokirkner/isitdeployable/docker-build-http-proxy-env
Reviewer Review Type Date Requested Status
Ricardo Kirkner (community) Approve
Review via email: mp+329036@code.staging.launchpad.net

Commit message

no need to override http_proxy env var for apt

just need to pass the lowercase variable (http_proxy, not HTTP_PROXY) as the build-arg

To post a comment you must log in.
234. By Ricardo Kirkner

re-added BUILD_REVISION ARG

Revision history for this message
Ricardo Kirkner (ricardokirkner) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches