Merge lp://staging/~ricardokirkner/django-preflight/support-django-1.7-1.11 into lp://staging/django-preflight

Proposed by Ricardo Kirkner
Status: Merged
Approved by: Ricardo Kirkner
Approved revision: 33
Merged at revision: 32
Proposed branch: lp://staging/~ricardokirkner/django-preflight/support-django-1.7-1.11
Merge into: lp://staging/django-preflight
Diff against target: 1096 lines (+443/-297)
28 files modified
doc/conf.py (+5/-5)
doc/install.rst (+4/-7)
example_project/app/admin.py (+3/-0)
example_project/app/models.py (+3/-0)
example_project/app/preflight.py (+39/-0)
example_project/app/templates/base.html (+57/-0)
example_project/app/tests.py (+3/-0)
example_project/app/views.py (+3/-0)
example_project/example_project/settings.py (+98/-0)
example_project/example_project/settings_17.py (+83/-0)
example_project/example_project/urls.py (+10/-0)
example_project/example_project/wsgi.py (+16/-0)
example_project/manage.py (+10/-0)
preflight/__init__.py (+4/-2)
preflight/apps.py (+6/-0)
preflight/management/commands/preflight.py (+3/-3)
preflight/models.py (+6/-6)
preflight/tests.py (+38/-21)
preflight/urls.py (+14/-6)
preflight/views.py (+2/-4)
preflight_example_project/app/preflight.py (+0/-39)
preflight_example_project/app/templates/base.html (+0/-57)
preflight_example_project/manage.py (+0/-13)
preflight_example_project/run.py (+0/-29)
preflight_example_project/settings.py (+0/-60)
preflight_example_project/urls.py (+0/-14)
setup.py (+0/-1)
tox.ini (+36/-30)
To merge this branch: bzr merge lp://staging/~ricardokirkner/django-preflight/support-django-1.7-1.11
Reviewer Review Type Date Requested Status
Fabián Ezequiel Gallina (community) Approve
Review via email: mp+322476@code.staging.launchpad.net

Commit message

fixed preflight compatibility with django 1.7 - 1.11

dropped support for django < 1.7
dropped support for django 2.6

Description of the change

Make preflight compatible with django 1.7 to 1.11

A few things needed to be dropped from the supported list of features

- python 2.6
- django < 1.7
- gargoyle for django >= 1.9 (because gargoyle itself is no longer maintained and is not compatible with django 1.9)

To post a comment you must log in.
Revision history for this message
Fabián Ezequiel Gallina (fgallina) wrote :

added super minor comments, it's looking good already.

Revision history for this message
Ricardo Kirkner (ricardokirkner) :
33. By Ricardo Kirkner

fixes per review

Revision history for this message
Fabián Ezequiel Gallina (fgallina) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches