Merge lp://staging/~ricardokirkner/django-pgtools/fix-role-username-unescaped into lp://staging/django-pgtools
Proposed by
Ricardo Kirkner
| Status: | Merged |
|---|---|
| Approved by: | Ricardo Kirkner |
| Approved revision: | 14 |
| Merged at revision: | 11 |
| Proposed branch: | lp://staging/~ricardokirkner/django-pgtools/fix-role-username-unescaped |
| Merge into: | lp://staging/django-pgtools |
| Diff against target: |
323 lines (+90/-55) 6 files modified
pgtools/dbrole.py (+20/-12) pgtools/dbuser.py (+11/-7) pgtools/management/commands/grantuser.py (+9/-8) pgtools/tests.py (+48/-26) requirements.txt (+1/-1) tox.ini (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~ricardokirkner/django-pgtools/fix-role-username-unescaped |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| William Grant (community) | code | Approve | |
| Daniel Manrique (community) | Approve | ||
|
Review via email:
|
|||
Commit message
escape role and username properly
To post a comment you must log in.
Revision history for this message
| William Grant (wgrant) | # |
review:
Approve
(code)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Weird! LGTM, I tried to ensure the quote shuffling looks OK but ooh, all those quotes/double quotes...