Merge lp://staging/~ricardokirkner/django-openid-auth/custom-user-groups into lp://staging/django-openid-auth
Proposed by
Ricardo Kirkner
Status: | Merged |
---|---|
Approved by: | Ricardo Kirkner |
Approved revision: | 130 |
Merged at revision: | 125 |
Proposed branch: | lp://staging/~ricardokirkner/django-openid-auth/custom-user-groups |
Merge into: | lp://staging/django-openid-auth |
Diff against target: |
232 lines (+116/-12) 5 files modified
django_openid_auth/auth.py (+50/-6) django_openid_auth/tests/models.py (+9/-0) django_openid_auth/tests/test_auth.py (+49/-3) setup.py (+2/-2) tox.ini (+6/-1) |
To merge this branch: | bzr merge lp://staging/~ricardokirkner/django-openid-auth/custom-user-groups |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Fabián Ezequiel Gallina (community) | Approve | ||
Daniel Manrique (community) | Approve | ||
Review via email: mp+315163@code.staging.launchpad.net |
Commit message
support custom user group model
also properly support django 1.6 up to 1.10
To post a comment you must log in.
LGTM code-wise, I'm not very knowledgeable on the subtleties of django-openid-auth but this seems to make sense. +1 but maybe you want another review. OTOH this is simple enough that if your tests show it works, we could go ahead.