Canonical Click Reviewers tools (obsolete)

Merge lp://staging/~ricardokirkner/click-reviewers-tools/fetch-framework-data into lp://staging/click-reviewers-tools

Proposed by Ricardo Kirkner on 2014-11-11

Status:	Merged
Merged at revision:	282
Proposed branch:	lp://staging/~ricardokirkner/click-reviewers-tools/fetch-framework-data
Merge into:	lp://staging/click-reviewers-tools
Diff against target:	161 lines (+45/-36) 5 files modified clickreviews/cr_lint.py (+1/-3) clickreviews/frameworks.py (+2/-3) clickreviews/tests/test_cr_lint.py (+42/-6) data/frameworks.json (+0/-23) debian/rules (+0/-1)
To merge this branch:	bzr merge lp://staging/~ricardokirkner/click-reviewers-tools/fetch-framework-data
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Jamie Strandboge (community)		Approve on 2014-11-11
Daniel Holbach (community)	2014-11-11	Needs Information on 2014-11-11
Review via email: mp+241427@code.staging.launchpad.net

fetch framework data before running framework related checks

283. By Ricardo Kirkner on 2014-11-11: remove no longer needed frameworks.json file

Revision history for this message

Daniel Holbach (dholbach) wrote on 2014-11-11:

The test suite is run during the package build, on build machines which don't have access to the net... will this use-case still work?

review: Needs Information

284. By Ricardo Kirkner on 2014-11-11: avoid tests fetching frameworks from network or local file
285. By Ricardo Kirkner on 2014-11-11: do not fetch frameworks from network when building deb package

Revision history for this message

Jamie Strandboge (jdstrand) wrote on 2014-11-11:

Daniel-- Ricardo was mocking out the rest of the test cases when you responded (we discussed it on IRC).

Ricardo, this looks good.

review: Approve

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

People subscribed via source and target branches

to all changes: