Merge lp://staging/~ricardokirkner/canonical-identity-provider/saml-no-clobber-issuer into lp://staging/canonical-identity-provider/release
Proposed by
Ricardo Kirkner
| Status: | Merged |
|---|---|
| Approved by: | Ricardo Kirkner |
| Approved revision: | no longer in the source branch. |
| Merge reported by: | Otto Co-Pilot |
| Merged at revision: | not available |
| Proposed branch: | lp://staging/~ricardokirkner/canonical-identity-provider/saml-no-clobber-issuer |
| Merge into: | lp://staging/canonical-identity-provider/release |
| Diff against target: |
138 lines (+50/-9) 3 files modified
src/ubuntu_sso_saml/processors.py (+2/-2) src/ubuntu_sso_saml/tests/test_processors.py (+47/-6) src/ubuntu_sso_saml/utils.py (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~ricardokirkner/canonical-identity-provider/saml-no-clobber-issuer |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel Manrique (community) | Approve | ||
|
Review via email:
|
|||
Commit message
keep AuthnRequest Issuer in REQUEST_ISSUER to avoid clobbering system-wide ISSUER value
saml2idp keeps the system-wide issuer (which is used when rendering the saml response) in the ISSUER key; storing the AuthnRequest issuer in that key was breaking saml responses (as they'd report as being issued by the SP instead of the IdP).
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Oops... looks OK to put this in a different dict key.
Thanks!