Merge lp://staging/~ricardokirkner/canonical-identity-provider/saml-expose-openid-url into lp://staging/canonical-identity-provider/release
Proposed by
Ricardo Kirkner
| Status: | Merged |
|---|---|
| Approved by: | Ricardo Kirkner |
| Approved revision: | no longer in the source branch. |
| Merge reported by: | Otto Co-Pilot |
| Merged at revision: | not available |
| Proposed branch: | lp://staging/~ricardokirkner/canonical-identity-provider/saml-expose-openid-url |
| Merge into: | lp://staging/canonical-identity-provider/release |
| Diff against target: |
31 lines (+15/-0) 2 files modified
src/ubuntu_sso_saml/processors.py (+2/-0) src/ubuntu_sso_saml/tests/test_processors.py (+13/-0) |
| To merge this branch: | bzr merge lp://staging/~ricardokirkner/canonical-identity-provider/saml-expose-openid-url |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel Manrique (community) | Approve | ||
|
Review via email:
|
|||
Commit message
support exposing openid url as a saml attribute
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
What does the openid url look like?
Looks good and should be harmless even if the URL is something horrid that breaks things, because we can just simply edit the attributes to not use it while we fix any breakage.