Merge lp://staging/~rharding/launchpad/translatables into lp://staging/launchpad
| Status: | Work in progress |
|---|---|
| Proposed branch: | lp://staging/~rharding/launchpad/translatables |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
86 lines (+44/-1) 2 files modified
lib/lp/registry/model/projectgroup.py (+2/-0) lib/lp/registry/tests/test_projectgroup.py (+42/-1) |
| To merge this branch: | bzr merge lp://staging/~rharding/launchpad/translatables |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Launchpad code reviewers | Pending | ||
|
Review via email:
|
|||
Commit message
Update projectgroup.
Description of the change
= Summary =
The .translations property and then getTranslatable methods it calls do not
take the privacy filter into account when querying.
== Pre Implementation ==
Talked with Deryck. getTranslatable is a method on both product and
projectgroup. In order to keep the api consistant we use the launchbag here as
was done in the product version of the method.
== Implementation Notes ==
Simple case of get the user and add the privacy filter to the query.
has_translatables() is based off the count of .translatables so this fixes
both points noted in the card.
== Tests ==
lib/lp/
Unmerged revisions
- 16298. By Richard Harding
-
lint
- 16297. By Richard Harding
-
Update the translatables to take information type into account
