Merge lp://staging/~rharding/launchpad/bug_814697_missing_spinner into lp://staging/launchpad
| Status: | Merged |
|---|---|
| Approved by: | Graham Binns |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 14365 |
| Proposed branch: | lp://staging/~rharding/launchpad/bug_814697_missing_spinner |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
14 lines (+1/-1) 1 file modified
lib/lp/code/templates/branch-macros.pt (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~rharding/launchpad/bug_814697_missing_spinner |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Graham Binns (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
[r=gmb][bug=814697] Add spinner to the code/branch-macros for displaying a group of revisions. Update the spinner to one with a transparent background to make it appear better on the grey background.
Description of the change
= Summary =
The inline diff loading wasn't showing our spinner graphic.
== Proposed Fix ==
Added the spinner to the hidden text in the template macro that's shown while the ajax request for the diff is loading.
== Implementation Details ==
Our original spinner was a .gif ona white background. In this location, it needs to display properly on a grey background. Per a conversation with Deryck and notes from Huw, loaded the 'indicator' style spinner from http://
One note is that since the .gif is transparent, we might see some small artifacts around the edges. The graphic is small and busy enough that I don't think it's an issue and the advantage of one true spinner to rule them all is worth the trade off.
== Q/A ==
Load a page with the diffs within the branch and click "Changes added by revision"
For example: https:/
You should now see a spinner. All other spinner instances should also show the new graphic on a transparent background.
| Graham Binns (gmb) | # |
