Merge lp://staging/~rharding/juju-gui/browserview into lp://staging/juju-gui/experimental
Proposed by
Richard Harding
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~rharding/juju-gui/browserview |
| Merge into: | lp://staging/juju-gui/experimental |
| Diff against target: |
544 lines (+492/-0) 7 files modified
app/app.js (+2/-0) app/models/browser.js (+166/-0) app/modules-debug.js (+8/-0) app/templates/browser.handlebars (+3/-0) app/views/browser.js (+170/-0) test/index.html (+1/-0) test/test_browser.js (+142/-0) |
| To merge this branch: | bzr merge lp://staging/~rharding/juju-gui/browserview |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Juju GUI Hackers | Pending | ||
|
Review via email:
|
|||
Description of the change
Add initial frame BrowserView for charm browser.
- NOTE: this is not wired into anything. It's just new code to prepare/setup
framing for the browser.
- Add the overall module juju-browser, juju-browser-models
- Start the process of the main BrowserView that will contain all UX for
browsing.
- Add first couple of tests that verify it renders/responds to an event.
- Add the model for the Filter to track current view status. Test event hooks
between view and Filter model.
To post a comment you must log in.
Revision history for this message
| j.c.sackett (jcsackett) wrote | # |
Unmerged revisions
- 399. By Richard Harding
-
lint
- 398. By Richard Harding
-
Update with trunk
- 397. By Richard Harding
-
Add a test for the reset filter event
- 396. By Richard Harding
-
Add in the filter model to use in the browser main view
- 395. By Richard Harding
-
lint lint lint
- 394. By Richard Harding
-
Update to have some passing tests around the browser view
- 393. By Richard Harding
-
Initial stab at browser gui code
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
lgtm.
I have one question about the stuff in the top of your testfile, but
it's not a blocker. Feel free to answer in IRC.
https:/
File test/test_
https:/
test/test_
What's this for?
https:/