Prometheus libvirt exporter charm

Merge ~rgildein/charm-prometheus-libvirt-exporter:dashboards/remove-flag into charm-prometheus-libvirt-exporter:master

  1. Git
  2. lp:~rgildein/charm-prometheus-libvirt-exporter
  3. dashboards/remove-flag
  4. Merge into master
Proposed by Robert Gildein
Status: Merged
Approved by: Ramesh Sattaru
Approved revision: 5de5d8164bd078dd58d58cd7c844333d75f4cffc
Merged at revision: 5e0c36dc0d53d369c99682b069a4591bcfbc3f5c
Proposed branch: ~rgildein/charm-prometheus-libvirt-exporter:dashboards/remove-flag
Merge into: charm-prometheus-libvirt-exporter:master
Diff against target: 44 lines (+0/-5)
1 file modified
src/reactive/prometheus-libvirt-exporter.py (+0/-5)
Reviewer Review Type Date Requested Status
Ramesh Sattaru (community) Approve
🤖 prod-jenkaas-bootstack continuous-integration Approve
Giuseppe Petralia Approve
Review via email: mp+438666@code.staging.launchpad.net

Commit message

remove flag to be able connect multiple Grafana

Removing unnecessary flag so registration of dashboard is triggered
every time if new relation joined.

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Giuseppe Petralia (peppepetra) wrote :

lgtm, thanks for that.

review: Approve
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

PASSED: Continuous integration, rev:5de5d8164bd078dd58d58cd7c844333d75f4cffc
https://jenkins.canonical.com/bootstack/job/lp-charm-prometheus-libvirt-exporter-ci/1/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/bootstack/job/lp-charm-test-functest/227/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/89/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-charm-prometheus-libvirt-exporter-ci/1//rebuild

review: Approve (continuous-integration)
Revision history for this message
Ramesh Sattaru (rameshcan) :
review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 5e0c36dc0d53d369c99682b069a4591bcfbc3f5c

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: