Ubuntu Document Viewer App

Merge lp://staging/~renatofilho/ubuntu-docviewer-app/mir-libs into lp://staging/ubuntu-docviewer-app

  1. mir-libs
  2. Merge into lo-viewer
Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Pat McGowan
Approved revision: 363
Merged at revision: 362
Proposed branch: lp://staging/~renatofilho/ubuntu-docviewer-app/mir-libs
Merge into: lp://staging/ubuntu-docviewer-app
Diff against target: 32 lines (+7/-2)
1 file modified
snapcraft.yaml (+7/-2)
To merge this branch: bzr merge lp://staging/~renatofilho/ubuntu-docviewer-app/mir-libs
Reviewer Review Type Date Requested Status
Pat McGowan Approve
Jenkins Bot continuous-integration Approve
Review via email: mp+320623@code.staging.launchpad.net

Commit message

[snap] Connect with mir-libs content share.

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:362
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-ci/278/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/1022/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-ci/278/rebuild

review: Approve (continuous-integration)
lp://staging/~renatofilho/ubuntu-docviewer-app/mir-libs updated
362. By Renato Araujo Oliveira Filho

[snap] Connect with mir-libs content share.

Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

It needs to set it to
    content: mir0
to match the slot definition.

(even though this works for me with the locally installed snap)

review: Needs Fixing
lp://staging/~renatofilho/ubuntu-docviewer-app/mir-libs updated
363. By Renato Araujo Oliveira Filho

Use correct mir slot name.

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:363
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-ci/279/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/1028/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-ci/279/rebuild

review: Approve (continuous-integration)
Revision history for this message
Pat McGowan (pat-mcgowan) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches