qtorganizer5-eds

Merge lp://staging/~renatofilho/qtorganizer5-eds/fix-signal-order into lp://staging/~ubuntu-sdk-team/qtorganizer5-eds/trunk

  1. fix-signal-order
  2. Merge into trunk
Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 15
Merged at revision: 13
Proposed branch: lp://staging/~renatofilho/qtorganizer5-eds/fix-signal-order
Merge into: lp://staging/~ubuntu-sdk-team/qtorganizer5-eds/trunk
Diff against target: 127 lines (+70/-4)
3 files modified
qorganizer/qorganizer-eds-removerequestdata.cpp (+1/-1)
qorganizer/qorganizer-eds-saverequestdata.cpp (+0/-2)
tests/unittest/event-test.cpp (+69/-1)
To merge this branch: bzr merge lp://staging/~renatofilho/qtorganizer5-eds/fix-signal-order
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Gustavo Pichorim Boiko (community) Approve
Review via email: mp+184783@code.staging.launchpad.net

Commit message

Avoid emit signal item removed before query finish.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:13
http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-ci/3/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-saucy-amd64-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-saucy-armhf-ci/3
        deb: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-saucy-armhf-ci/3/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-saucy-i386-ci/3

Click here to trigger a rebuild:
http://s-jenkins:8080/job/qtorganizer5-eds-ci/3/rebuild

review: Approve (continuous-integration)
lp://staging/~renatofilho/qtorganizer5-eds/fix-signal-order updated
14. By Renato Araujo Oliveira Filho

Removed use of extra variable to store the removed ids.

15. By Renato Araujo Oliveira Filho

Created unit test for check the order that the signal is fired.

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:14
http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-ci/4/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-saucy-amd64-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-saucy-armhf-ci/4
        deb: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-saucy-armhf-ci/4/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-saucy-i386-ci/4

Click here to trigger a rebuild:
http://s-jenkins:8080/job/qtorganizer5-eds-ci/4/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches