qtorganizer5-eds

Merge lp://staging/~renatofilho/qtorganizer5-eds/fix-match-all into lp://staging/~ubuntu-sdk-team/qtorganizer5-eds/trunk

  1. fix-match-all
  2. Merge into trunk
Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Zoltan Balogh
Approved revision: 17
Merged at revision: 17
Proposed branch: lp://staging/~renatofilho/qtorganizer5-eds/fix-match-all
Merge into: lp://staging/~ubuntu-sdk-team/qtorganizer5-eds/trunk
Diff against target: 111 lines (+10/-25)
4 files modified
qorganizer/qorganizer-eds-fetchrequestdata.cpp (+8/-6)
qorganizer/qorganizer-eds-fetchrequestdata.h (+1/-1)
qorganizer/qorganizer-eds-viewwatcher.cpp (+1/-16)
qorganizer/qorganizer-eds-viewwatcher.h (+0/-2)
To merge this branch: bzr merge lp://staging/~renatofilho/qtorganizer5-eds/fix-match-all
Reviewer Review Type Date Requested Status
Nekhelesh Ramananthan (community) Approve
Olivier Tilloy (community) Approve
PS Jenkins bot continuous-integration Approve
Ubuntu SDK team Pending
Review via email: mp+191080@code.staging.launchpad.net

Commit message

Used a proper match all query string.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:17
http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-ci/13/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-saucy-amd64-ci/13
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-saucy-armhf-ci/13
        deb: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-saucy-armhf-ci/13/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-saucy-i386-ci/13

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/qtorganizer5-eds-ci/13/rebuild

review: Approve (continuous-integration)
Revision history for this message
Olivier Tilloy (osomon) wrote :

I haven’t actually verified that this fixes bug #1236390, however the code looks sound to me.

review: Approve
Revision history for this message
David Planella (dpm) wrote :

In order to make testing easier, there are now packages available containing this change in the core apps PPA:

https://code.launchpad.net/~ubuntu-touch-coreapps-drivers/+archive/daily/+packages?field.name_filter=organizer&field.status_filter=published&field.series_filter=saucy

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

This does not fix bug #1236390. I installed the PPA and installed the qtorganizer5-eds package and on running the clock app through the qtcreator, the alarms are not saved. Console output log can be found at http://paste.ubuntu.com/6240020/

I did also test the clock app installed on the phone (click app), and still didnnt notice any alarms being saved (Image 97).

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Okay so on testing the armhf deb package that I downloaded from this MP at http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-saucy-armhf-ci/13, alarms can now be saved properly :) .. Approving!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches