qtorganizer5-eds

Merge lp://staging/~renatofilho/qtorganizer5-eds/fix-1347836 into lp://staging/qtorganizer5-eds

  1. fix-1347836
  2. Merge into trunk
Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Bill Filler
Approved revision: 74
Merged at revision: 82
Proposed branch: lp://staging/~renatofilho/qtorganizer5-eds/fix-1347836
Merge into: lp://staging/qtorganizer5-eds
Prerequisite: lp://staging/~renatofilho/qtorganizer5-eds/fix-1440878
Diff against target: 192 lines (+57/-11)
5 files modified
organizer/qorganizer-eds-source-registry.cpp (+16/-2)
organizer/qorganizer-eds-source-registry.h (+4/-1)
tests/unittest/collections-test.cpp (+34/-4)
tests/unittest/event-test.cpp (+0/-2)
tests/unittest/run-eds-test.sh (+3/-2)
To merge this branch: bzr merge lp://staging/~renatofilho/qtorganizer5-eds/fix-1347836
Reviewer Review Type Date Requested Status
Kunal Parmar (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+255726@code.staging.launchpad.net

This proposal supersedes a proposal from 2014-10-21.

Commit message

Added a new extra metadata property in collection (read-only property).

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:66
http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-ci/184/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-utopic-amd64-ci/42/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-utopic-armhf-ci/42/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-utopic-i386-ci/42/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtorganizer5-eds-ci/184/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:67
http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-ci/186/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-utopic-amd64-ci/44
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-utopic-armhf-ci/44/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-utopic-i386-ci/44/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtorganizer5-eds-ci/186/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:67
http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-ci/187/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-utopic-amd64-ci/45/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-utopic-armhf-ci/45
        deb: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-utopic-armhf-ci/45/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-utopic-i386-ci/45

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtorganizer5-eds-ci/187/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Kunal Parmar (pkunal-parmar) wrote : Posted in a previous version of this proposal

I am not getting readonly true for birth day calendar

qml: Personal - collectin-readonly : false
qml: Birthdays & Anniversaries - collectin-readonly : false

Where creating event on Birthdays calendar fails as its readonly

ail to create items: Cannot create calendar object: Permission denied

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:68
http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-ci/188/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-utopic-amd64-ci/46/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-utopic-armhf-ci/46
        deb: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-utopic-armhf-ci/46/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-utopic-i386-ci/46

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtorganizer5-eds-ci/188/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:70
http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-ci/204/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-amd64-ci/11/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-armhf-ci/11/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-i386-ci/11/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtorganizer5-eds-ci/204/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:71
http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-ci/205/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-amd64-ci/12/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-armhf-ci/12/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-i386-ci/12/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtorganizer5-eds-ci/205/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~renatofilho/qtorganizer5-eds/fix-1347836 updated
72. By Renato Araujo Oliveira Filho

Update collection test.

Instead of compare all the colection data to check if it exists, I am using only the collection id in case of the other properties changed during the process.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:72
http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-ci/207/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-amd64-ci/14
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-armhf-ci/14
        deb: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-armhf-ci/14/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-i386-ci/14

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtorganizer5-eds-ci/207/rebuild

review: Approve (continuous-integration)
lp://staging/~renatofilho/qtorganizer5-eds/fix-1347836 updated
73. By Renato Araujo Oliveira Filho

Fix collection test.

Wait for collection to be writable before try to remove id.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:73
http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-ci/216/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-amd64-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-armhf-ci/23
        deb: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-armhf-ci/23/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-i386-ci/23/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtorganizer5-eds-ci/216/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~renatofilho/qtorganizer5-eds/fix-1347836 updated
74. By Renato Araujo Oliveira Filho

Do not try to compare secs on unit test.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:74
http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-ci/217/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-amd64-ci/24/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-armhf-ci/24
        deb: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-armhf-ci/24/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-i386-ci/24/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtorganizer5-eds-ci/217/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

tested and works great for me.

Thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches