Merge lp://staging/~renatofilho/qtorganizer5-eds/changes-notify into lp://staging/~ubuntu-sdk-team/qtorganizer5-eds/trunk

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 20
Merged at revision: 15
Proposed branch: lp://staging/~renatofilho/qtorganizer5-eds/changes-notify
Merge into: lp://staging/~ubuntu-sdk-team/qtorganizer5-eds/trunk
Diff against target: 1229 lines (+583/-119)
14 files modified
qorganizer/CMakeLists.txt (+2/-0)
qorganizer/qorganizer-eds-collection-engineid.cpp (+25/-19)
qorganizer/qorganizer-eds-collection-engineid.h (+2/-2)
qorganizer/qorganizer-eds-engine.cpp (+180/-47)
qorganizer/qorganizer-eds-engine.h (+10/-3)
qorganizer/qorganizer-eds-engineid.cpp (+21/-19)
qorganizer/qorganizer-eds-engineid.h (+4/-4)
qorganizer/qorganizer-eds-fetchrequestdata.cpp (+1/-0)
qorganizer/qorganizer-eds-requestdata.cpp (+6/-2)
qorganizer/qorganizer-eds-savecollectionrequestdata.cpp (+1/-1)
qorganizer/qorganizer-eds-viewwatcher.cpp (+211/-0)
qorganizer/qorganizer-eds-viewwatcher.h (+63/-0)
tests/unittest/collections-test.cpp (+28/-19)
tests/unittest/itemid-test.cpp (+29/-3)
To merge this branch: bzr merge lp://staging/~renatofilho/qtorganizer5-eds/changes-notify
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Gustavo Pichorim Boiko (community) Approve
Review via email: mp+189487@code.staging.launchpad.net

This proposal supersedes a proposal from 2013-09-25.

Commit message

*Fixed default source/collection load;
*Implemented changes notify.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
17. By Renato Araujo Oliveira Filho

Fixed crash during view watcher destructor.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
18. By Renato Araujo Oliveira Filho

Implemented parse for attendee list.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
19. By Renato Araujo Oliveira Filho

Removed tests which need EDS (causes problem on jenkins)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
20. By Renato Araujo Oliveira Filho

removed duplicated code.

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)
Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

works fine for calendar usecases.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches