mediaplayer-app

Merge lp://staging/~renatofilho/mediaplayer-app/video-selector into lp://staging/mediaplayer-app

  1. video-selector
  2. Merge into trunk
Proposed by Renato Araujo Oliveira Filho
Status: Needs review
Proposed branch: lp://staging/~renatofilho/mediaplayer-app/video-selector
Merge into: lp://staging/mediaplayer-app
Diff against target: 638 lines (+360/-67)
10 files modified
CMakeLists.txt (+2/-0)
debian/control (+1/-0)
po/mediaplayer-app.pot (+51/-37)
src/CMakeLists.txt (+8/-2)
src/mediaplayer.cpp (+2/-0)
src/qml/VideoSelector.qml (+133/-0)
src/qml/player.qml (+27/-20)
src/qml/player/VideoPlayer.qml (+2/-8)
src/videos-model.cpp (+82/-0)
src/videos-model.h (+52/-0)
To merge this branch: bzr merge lp://staging/~renatofilho/mediaplayer-app/video-selector
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Needs Fixing
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+246217@code.staging.launchpad.net

Commit message

Show video selector dialog while opening the app without a video url as argument.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:318
http://jenkins.qa.ubuntu.com/job/mediaplayer-app-ci/251/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/780
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/385
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-vivid-amd64-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-vivid-armhf-ci/9
        deb: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-vivid-armhf-ci/9/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-vivid-i386-ci/9
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/679
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/778
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/778/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17016
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/316
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/391
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/391/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mediaplayer-app-ci/251/rebuild

review: Needs Fixing (continuous-integration)
Reply
lp://staging/~renatofilho/mediaplayer-app/video-selector updated
319. By Renato Araujo Oliveira Filho

Updated pot file.
Updated VideoSelector dialog visual.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:319
http://jenkins.qa.ubuntu.com/job/mediaplayer-app-ci/252/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/785
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/386
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-vivid-amd64-ci/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-vivid-armhf-ci/10
        deb: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-vivid-armhf-ci/10/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-vivid-i386-ci/10
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/683
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/783
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/783/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17032
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/317
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/393
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/393/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mediaplayer-app-ci/252/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:319
https://jenkins.canonical.com/system-apps/job/lp-mediaplayer-app-ci/3/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/706/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-0-fetch/706/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-mediaplayer-app-ci/3/rebuild

review: Needs Fixing (continuous-integration)
Reply

Unmerged revisions

319. By Renato Araujo Oliveira Filho

Updated pot file.
Updated VideoSelector dialog visual.

318. By Renato Araujo Oliveira Filho

Show video selector dialog while opening the app without a video url as argument.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches