Transfer Indicator

Merge lp://staging/~renatofilho/indicator-transfer/app-id-dm into lp://staging/indicator-transfer/15.10

  1. app-id-dm
  2. Merge into trunk.15.10
Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Charles Kerr
Approved revision: 41
Merged at revision: 38
Proposed branch: lp://staging/~renatofilho/indicator-transfer/app-id-dm
Merge into: lp://staging/indicator-transfer/15.10
Diff against target: 614 lines (+254/-210)
3 files modified
CMakeLists.txt (+2/-1)
debian/rules (+2/-1)
src/dm-plugin/dm-source.cpp (+250/-208)
To merge this branch: bzr merge lp://staging/~renatofilho/indicator-transfer/app-id-dm
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+272106@code.staging.launchpad.net

Commit message

Removed content hub dep from download manager plugin.

Uses download "app-id" property to show application information.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:36
http://jenkins.qa.ubuntu.com/job/indicator-transfer-ci/39/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-transfer-wily-amd64-ci/21
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-transfer-wily-armhf-ci/21
        deb: http://jenkins.qa.ubuntu.com/job/indicator-transfer-wily-armhf-ci/21/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-transfer-ci/39/rebuild

review: Approve (continuous-integration)
lp://staging/~renatofilho/indicator-transfer/app-id-dm updated
37. By Renato Araujo Oliveira Filho

Fixed app info retrieve from click packages.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:37
http://jenkins.qa.ubuntu.com/job/indicator-transfer-ci/40/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-transfer-wily-amd64-ci/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-transfer-wily-armhf-ci/22
        deb: http://jenkins.qa.ubuntu.com/job/indicator-transfer-wily-armhf-ci/22/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-transfer-ci/40/rebuild

review: Approve (continuous-integration)
lp://staging/~renatofilho/indicator-transfer/app-id-dm updated
38. By Renato Araujo Oliveira Filho

Does not show downloads which has 'ShowInIndicator' marked as false.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:38
http://jenkins.qa.ubuntu.com/job/indicator-transfer-ci/41/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-transfer-wily-amd64-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-transfer-wily-armhf-ci/23
        deb: http://jenkins.qa.ubuntu.com/job/indicator-transfer-wily-armhf-ci/23/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-transfer-ci/41/rebuild

review: Approve (continuous-integration)
lp://staging/~renatofilho/indicator-transfer/app-id-dm updated
39. By Renato Araujo Oliveira Filho

Fixed memory leak.

Revision history for this message
Charles Kerr (charlesk) wrote :

Comments inline. Mostly looks good, a couple of minor variant leaks need fixing

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:39
http://jenkins.qa.ubuntu.com/job/indicator-transfer-ci/42/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-transfer-wily-amd64-ci/24
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-transfer-wily-armhf-ci/24
        deb: http://jenkins.qa.ubuntu.com/job/indicator-transfer-wily-armhf-ci/24/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-transfer-ci/42/rebuild

review: Approve (continuous-integration)
lp://staging/~renatofilho/indicator-transfer/app-id-dm updated
40. By Renato Araujo Oliveira Filho

Parse "package-name" from download metadata.

"package-name" is used by update-manager when download update for exists apps.

41. By Renato Araujo Oliveira Filho

Fixed memory leaks.

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

> Comments inline. Mostly looks good, a couple of minor variant leaks need
> fixing
All leaks fixed.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:41
http://jenkins.qa.ubuntu.com/job/indicator-transfer-ci/43/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-transfer-wily-amd64-ci/25
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-transfer-wily-armhf-ci/25
        deb: http://jenkins.qa.ubuntu.com/job/indicator-transfer-wily-armhf-ci/25/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-transfer-ci/43/rebuild

review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

Some nice improvements in this patch. LGTM

review: Approve
lp://staging/~renatofilho/indicator-transfer/app-id-dm updated
42. By Renato Araujo Oliveira Filho

Fixed application icon name set.

43. By Renato Araujo Oliveira Filho

Trunk merged.

44. By Renato Araujo Oliveira Filho

Metadata.app_id has priority over destinationAppId.

45. By Renato Araujo Oliveira Filho

Run test sequential.

46. By Renato Araujo Oliveira Filho

Fix build rules.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches