Indicator Date and Time

CMakeLists.txt (+4/-1)
data/CMakeLists.txt (+1/-1)
data/indicator-datetime.desktop.in (+1/-0)
debian/control (+4/-0)
include/datetime/actions-live.h (+13/-10)
include/datetime/actions.h (+4/-8)
include/notifications/haptic.h (+1/-1)
include/notifications/notifications.h (+8/-1)
src/actions-live.cpp (+71/-63)
src/actions.cpp (+34/-58)
src/haptic.cpp (+15/-9)
src/main.cpp (+3/-1)
src/notifications.cpp (+169/-5)
src/snap.cpp (+14/-3)
tests/actions-mock.h (+18/-38)
tests/test-actions.cpp (+8/-8)
tests/test-live-actions.cpp (+31/-9)
tests/test-notification.cpp (+1/-1)
tests/test-sound.cpp (+1/-1)

To merge this branch:

bzr merge lp://staging/~renatofilho/indicator-datetime/notify-missing-alarm

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Needs Fixing on 2016-05-02
Charles Kerr (community)		2016-04-19	Approve on 2016-04-29
Review via email: mp+292270@code.staging.launchpad.net

This proposal supersedes a proposal from 2016-04-19.

Commit message

Post message on messaging menu if the notification get timeout.

Description of the change

QA: Jenkins is failing because it is missing the new version of libubuntu-app-launch2-dev (>= 0.9)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-04-19:

PASSED: Continuous integration, rev:462
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/374/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-amd64-ci/64
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/64
        deb: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/64/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-ci/374/rebuild

review: Approve (continuous-integration)

lp://staging/~renatofilho/indicator-datetime/notify-missing-alarm updated on 2016-04-19

463. By Renato Araujo Oliveira Filho on 2016-04-19: Fixed crash when clicking on messaging menu.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-04-19:

PASSED: Continuous integration, rev:463
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/375/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-amd64-ci/65
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/65
        deb: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/65/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-ci/375/rebuild

review: Approve (continuous-integration)

lp://staging/~renatofilho/indicator-datetime/notify-missing-alarm updated on 2016-04-20

464. By Renato Araujo Oliveira Filho on 2016-04-20: Fix memory leak on messaging_menu.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-04-20:

PASSED: Continuous integration, rev:464
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/376/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-amd64-ci/66
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/66
        deb: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/66/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-ci/376/rebuild

review: Approve (continuous-integration)

lp://staging/~renatofilho/indicator-datetime/notify-missing-alarm updated on 2016-04-20

465. By Renato Araujo Oliveira Filho on 2016-04-20: Vibrate only once when notification about calendar events.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-04-20:

PASSED: Continuous integration, rev:465
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/377/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-amd64-ci/67
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/67
        deb: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/67/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-ci/377/rebuild

review: Approve (continuous-integration)

Revision history for this message

Charles Kerr (charlesk) wrote on 2016-04-26:

I have a lot of questions about this.

review: Needs Information

Revision history for this message

Renato Araujo Oliveira Filho (renatofilho) wrote on 2016-04-26:

Some small fixes is on the way.

There is some replies inline.

lp://staging/~renatofilho/indicator-datetime/notify-missing-alarm updated on 2016-04-26

466. By Renato Araujo Oliveira Filho on 2016-04-26: Fixed as reviewer requested.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-04-26:

PASSED: Continuous integration, rev:466
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/378/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-amd64-ci/68
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/68
        deb: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/68/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-ci/378/rebuild

review: Approve (continuous-integration)

lp://staging/~renatofilho/indicator-datetime/notify-missing-alarm updated on 2016-04-26

467. By Renato Araujo Oliveira Filho on 2016-04-26: Make use of G_USEC_PER_SEC.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-04-26:

PASSED: Continuous integration, rev:467
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/379/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-amd64-ci/69
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/69
        deb: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/69/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-ci/379/rebuild

review: Approve (continuous-integration)

lp://staging/~renatofilho/indicator-datetime/notify-missing-alarm updated on 2016-04-27

468. By Renato Araujo Oliveira Filho on 2016-04-27: Update notifications to use the new calendar icon.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-04-27:

PASSED: Continuous integration, rev:468
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/380/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-amd64-ci/70
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/70
        deb: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/70/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-ci/380/rebuild

review: Approve (continuous-integration)

lp://staging/~renatofilho/indicator-datetime/notify-missing-alarm updated on 2016-04-27

469. By Renato Araujo Oliveira Filho on 2016-04-27: Use calendar app icon.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-04-27:

FAILED: Continuous integration, rev:469
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/381/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-amd64-ci/71/console
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/71/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-ci/381/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~renatofilho/indicator-datetime/notify-missing-alarm updated on 2016-04-27

470. By Renato Araujo Oliveira Filho on 2016-04-27: Only creates messaging menu if calendar app is instaled.
Update tests.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-04-27:

FAILED: Continuous integration, rev:470
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/382/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-amd64-ci/72/console
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/72/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-ci/382/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Charles Kerr (charlesk) wrote on 2016-04-28:

More code-level comments inline. Most are minor/suggestions, two NF

A few larger issues:

1. Again I'd /strongly/ prefer that ical events pass in their source desktop id as an x-prop. Not only would that eliminate the need for libubuntu-app-launch2-dev >= 0.9 but it would also let us have per-app sources, eg alarms wouldn't show up under the calendar icon. The approach in this patch works for calendars but assumes that the whole world is a calendar.

2. If we must use libubuntu-app-launch2-dev, can we confirm that it's going to make it into Xenial? It's awfully early to be breaking build compatibility with Xenial

review: Needs Fixing

Revision history for this message

Renato Araujo Oliveira Filho (renatofilho) wrote on 2016-04-28:

> More code-level comments inline. Most are minor/suggestions, two NF
>
> A few larger issues:
>
> 1. Again I'd /strongly/ prefer that ical events pass in their source desktop
> id as an x-prop. Not only would that eliminate the need for libubuntu-app-
> launch2-dev >= 0.9 but it would also let us have per-app sources, eg alarms
> wouldn't show up under the calendar icon. The approach in this patch works for
> calendars but assumes that the whole world is a calendar.
We can not guarantee that ical event will have their source id. I can change calendar app to add that, but old events will not have that. Events created by others apps (syncevolution, evolution, thuderbird, etc...) will not set that.
>
> 2. If we must use libubuntu-app-launch2-dev, can we confirm that it's going to
> make it into Xenial? It's awfully early to be breaking build compatibility
> with Xenial

I believe it is already in xenial, ppa builds it ok: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/landing-009/+packages