Merge lp://staging/~renatofilho/dialer-app/ab-new-header into lp://staging/dialer-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Bill Filler
Approved revision: 504
Merged at revision: 505
Proposed branch: lp://staging/~renatofilho/dialer-app/ab-new-header
Merge into: lp://staging/dialer-app
Diff against target: 62 lines (+14/-5)
3 files modified
src/qml/ContactEditorPage/DialerContactEditorPage.qml (+2/-2)
src/qml/ContactViewPage/DialerContactViewPage.qml (+1/-1)
tests/autopilot/dialer_app/__init__.py (+11/-2)
To merge this branch: bzr merge lp://staging/~renatofilho/dialer-app/ab-new-header
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Bill Filler (community) Needs Fixing
Review via email: mp+281776@code.staging.launchpad.net

Commit message

Use the new Addressbook header.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

code works, but many AP tests are now failing

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
504. By Renato Araujo Oliveira Filho

Update autopilot test to work with the new AB page header.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

The testes are failing because jenkins is not using the last address-book-package present on silo 55.

Works nice when using the right packages.

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :
Download full text (53.7 KiB)

Tests results ( Two failures not related with the changes)

phablet@ubuntu-phablet:~$ autopilot3 run dialer_app
Connecting modem /phonesim...
Setting modem /phonesim online...
Loading tests from: /usr/lib/python3/dist-packages

Tests running...
Loading contacts from: /usr/lib/python3/dist-packages/dialer_app//testdata/vcard.vcf
To apply changes to these parameters:
  modem-objpath
run:
  mc-tool reconnect ofono/ofono/account0
To apply changes to these parameters:
  modem-objpath
run:
  mc-tool reconnect ofono/ofono/account0
Loading contacts from: /usr/lib/python3/dist-packages/dialer_app//testdata/vcard.vcf
To apply changes to these parameters:
  modem-objpath
run:
  mc-tool reconnect ofono/ofono/account0
url-dispatcher stop/waiting
Loading contacts from: /usr/lib/python3/dist-packages/dialer_app//testdata/vcard.vcf
To apply changes to these parameters:
  modem-objpath
run:
  mc-tool reconnect ofono/ofono/account0
To apply changes to these parameters:
  modem-objpath
run:
  mc-tool reconnect ofono/ofono/account0
initctl: Unknown instance:
Loading contacts from: /usr/lib/python3/dist-packages/dialer_app//testdata/vcard.vcf
To apply changes to these parameters:
  modem-objpath
run:
  mc-tool reconnect ofono/ofono/account0
To apply changes to these parameters:
  modem-objpath
run:
  mc-tool reconnect ofono/ofono/account0
To apply changes to these parameters:
  modem-objpath
run:
  mc-tool reconnect ofono/ofono/account0
Loading contacts from: /usr/lib/python3/dist-packages/dialer_app//testdata/vcard.vcf
To apply changes to these parameters:
  modem-objpath
run:
  mc-tool reconnect ofono/ofono/account0
To apply changes to these parameters:
  modem-objpath
run:
  mc-tool reconnect ofono/ofono/account0
Loading contacts from: /usr/lib/python3/dist-packages/dialer_app//testdata/vcard.vcf
To apply changes to these parameters:
  modem-objpath
run:
  mc-tool reconnect ofono/ofono/account0
To apply changes to these parameters:
  modem-objpath
run:
  mc-tool reconnect ofono/ofono/account0
To apply changes to these parameters:
  modem-objpath
run:
  mc-tool reconnect ofono/ofono/account0
Loading contacts from: /usr/lib/python3/dist-packages/dialer_app//testdata/vcard.vcf
initctl: Unknown instance:
Loading contacts from: /usr/lib/python3/dist-packages/dialer_app//testdata/vcard.vcf
To apply changes to these parameters:
  modem-objpath
run:
  mc-tool reconnect ofono/ofono/account0
To apply changes to these parameters:
  modem-objpath
run:
  mc-tool reconnect ofono/ofono/account0
To apply changes to these parameters:
  modem-objpath
run:
  mc-tool reconnect ofono/ofono/account0
To apply changes to these parameters:
  modem-objpath
run:
  mc-tool reconnect ofono/ofono/account0
To apply changes to these parameters:
  modem-objpath
run:
  mc-tool reconnect ofono/ofono/account0
Loading contacts from: /usr/lib/python3/dist-packages/dialer_app//testdata/vcard.vcf
To apply changes to these parameters:
  modem-objpath
run:
  mc-tool reconnect ofono/ofono/account0
To apply changes to these parameters:
  modem-objpath
run:
  mc-tool reconnect ofono/ofono/account0
Loading contacts from: /usr/lib/python3/dist-packages/dialer_app//testdata/vcard.vcf
To apply changes to...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches