Merge into trunk : sim-card-import : Code : address-book-app

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Needs Fixing on 2015-03-18
Tiago Salem Herrmann (community)			Approve on 2015-03-18
Bill Filler (community)		2015-02-04	Needs Fixing on 2015-03-09
Review via email: mp+248562@code.staging.launchpad.net

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-04:

#

FAILED: Continuous integration, rev:366
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/723/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/26/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1167/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/538/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1165/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/647/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/723/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-02-04

367. By Renato Araujo Oliveira Filho on 2015-02-04: -show an active indicator while contacts is exported
-Fixed some problems during the sim card reader

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-04:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/725/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-02-05

368. By Renato Araujo Oliveira Filho on 2015-02-05: Wait for async modems interfaces.
369. By Renato Araujo Oliveira Filho on 2015-02-05: Check for modem interface before create the phonebook object.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-05:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/729/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-06:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/731/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-02-23

370. By Renato Araujo Oliveira Filho on 2015-02-23: Trunk Merged.
371. By Renato Araujo Oliveira Filho on 2015-02-23: Show Import from sim on contact list.
372. By Renato Araujo Oliveira Filho on 2015-02-23: Changed the buttom order on address-book-app header.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-23:

#

FAILED: Continuous integration, rev:371
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/748/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/51/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1492/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/639/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1490/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/753/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/748/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-23:

#

FAILED: Continuous integration, rev:372
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/749/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/52/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1493/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/640/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1491/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/754/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/749/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-02-23

373. By Renato Araujo Oliveira Filho on 2015-02-23: Updated test to work with the new visual.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-23:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/750/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-02-24

374. By Renato Araujo Oliveira Filho on 2015-02-24: Renamed Contact list used in SimCard import page.
375. By Renato Araujo Oliveira Filho on 2015-02-24: Move search button as first action to avid it to get hide if the app is called from dialer app.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-24:

#

PASSED: Continuous integration, rev:375
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/751/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/54
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1497
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/643
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1329
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1495
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1495/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18297
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/513
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/757
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/757/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/751/rebuild

review: Approve (continuous-integration)

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-02-24

376. By Renato Araujo Oliveira Filho on 2015-02-24: Change the importFrom buttons header invisilbe if the list is not empty.
377. By Renato Araujo Oliveira Filho on 2015-02-24: Avoid import contacts from sim twice.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-24:

#

FAILED: Continuous integration, rev:377
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/752/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/55
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1500
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/645/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1332
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1498
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1498/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18303
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/759/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/752/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-03-03

378. By Renato Araujo Oliveira Filho on 2015-03-03: Implemented autopilo test.
379. By Renato Araujo Oliveira Filho on 2015-03-03: Trunk merged.
380. By Renato Araujo Oliveira Filho on 2015-03-03: Fixed autopilot tests.
381. By Renato Araujo Oliveira Filho on 2015-03-03: Fixed autopilot tests.
382. By Renato Araujo Oliveira Filho on 2015-03-03: only run import_from_sim test if ofono 'phonesim' emulator is running.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-03:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/758/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-03:

#

FAILED: Continuous integration, rev:382
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/759/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/62/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1632/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/673/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1630/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/790/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/759/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-03-03

383. By Renato Araujo Oliveira Filho on 2015-03-03: Updated unit test.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-03:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/760/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-03-03

384. By Renato Araujo Oliveira Filho on 2015-03-03: Import missing library.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-04:

#

PASSED: Continuous integration, rev:384
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/761/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/64
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1635
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/676
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1449
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1633
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1633/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18523
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/538
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/793
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/793/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/761/rebuild

review: Approve (continuous-integration)

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-03-04

385. By Renato Araujo Oliveira Filho on 2015-03-04: Improve test.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-04:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/762/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-03-04

386. By Renato Araujo Oliveira Filho on 2015-03-04: Check for modem interface changes during the contact import.
387. By Renato Araujo Oliveira Filho on 2015-03-04: Create unit test for removing sim card during the contact import.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-04:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/763/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-03-04

388. By Renato Araujo Oliveira Filho on 2015-03-04: Fixed contacts import from a real sim.
389. By Renato Araujo Oliveira Filho on 2015-03-04: Removed extra debug messages.
390. By Renato Araujo Oliveira Filho on 2015-03-04: Renamed m_pendingModems

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-04:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/764/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-03-04

391. By Renato Araujo Oliveira Filho on 2015-03-04: Update python code syntax.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-04:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/765/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-03-05

392. By Renato Araujo Oliveira Filho on 2015-03-05: Trunk merged.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-05:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/766/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Bill Filler (bfiller) wrote on 2015-03-05:

#

A few issues:

1) The label on contact list page should say "Import contacts from SIM card" not "Import contacts from sim card"
2) There is currently a toolbar button (with arrow) on the first time contact list page (i.e. the page that displays "Import from Google", "Import from SIM card"). We should not show the toolbar button here as there is already an option in the list
3) The header title when doing import from sim should say "Import SIM Contacts" I think, as there is no indication where these are coming from
4) What happens in the dual-sim case if you have contacts on both sims? Does the view show all of them combined? (I would expect it to)
5) Is there a better icon we could get perhaps? This one looks like a Download/Save button to me
6) Wondering if we should always have the toolbar icon in a drawer? Whether it's by itself or with a sync button. This way we have text to describe what the action is and the icon becomes less import. Once we have settings we'll need a drawer probably anyay

review: Needs Fixing

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-03-05

393. By Renato Araujo Oliveira Filho on 2015-03-05: Avoid import empty string as contact.
394. By Renato Araujo Oliveira Filho on 2015-03-05: Does not show the "import from sim" if the list is empty.
395. By Renato Araujo Oliveira Filho on 2015-03-05: Fixed "Import contacts from SIM card" label.
396. By Renato Araujo Oliveira Filho on 2015-03-05: Update page title.
397. By Renato Araujo Oliveira Filho on 2015-03-05: Create a autopilot test for the new header behaviour.

Revision history for this message

Renato Araujo Oliveira Filho (renatofilho) wrote on 2015-03-05:

#

> A few issues:
>
> 1) The label on contact list page should say "Import contacts from SIM card"
> not "Import contacts from sim card"
Fixed on rev. 397

> 2) There is currently a toolbar button (with arrow) on the first time contact
> list page (i.e. the page that displays "Import from Google", "Import from SIM
> card"). We should not show the toolbar button here as there is already an
> option in the list
Fixed on rev. 394

> 3) The header title when doing import from sim should say "Import SIM
> Contacts" I think, as there is no indication where these are coming from
Fixed on rev. 395

> 4) What happens in the dual-sim case if you have contacts on both sims? Does
> the view show all of them combined? (I would expect it to)
Yes both contact list is showed as one list.

> 5) Is there a better icon we could get perhaps? This one looks like a
> Download/Save button to me
I am no happy with this icon, but I did not find any better icon.
I reported a bug some time ago about that: https://bugs.launchpad.net/ubuntu-themes/+bug/1424819

> 6) Wondering if we should always have the toolbar icon in a drawer? Whether
> it's by itself or with a sync button. This way we have text to describe what
> the action is and the icon becomes less import. Once we have settings we'll
> need a drawer probably anyay
this is a SDK component, the drawer appears automatically if we have more then 4 buttons (back on the left, more 3 on the right) this is not an application property.
And Olga told me that the import functionality is going to be moved to application settings, because this is an action that the user will do once.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-05:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/767/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-03-05

398. By Renato Araujo Oliveira Filho on 2015-03-05: Load contacts after a timeout to avoid multiple load during modem interface change.
Show a message if the contact list is empty.
399. By Renato Araujo Oliveira Filho on 2015-03-05: Update page title "SIM contacts".
400. By Renato Araujo Oliveira Filho on 2015-03-05: Does not show empty message if the contact list is busy.
401. By Renato Araujo Oliveira Filho on 2015-03-05: Show a error message if the import from sim fails.
402. By Renato Araujo Oliveira Filho on 2015-03-05: Make import from sim button always visible.
403. By Renato Araujo Oliveira Filho on 2015-03-05: Update autopilot tests.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-06:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/768/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-06:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/769/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-03-06

404. By Renato Araujo Oliveira Filho on 2015-03-06: Implement initial settings page.
405. By Renato Araujo Oliveira Filho on 2015-03-06: Updated autopilot tests.
406. By Renato Araujo Oliveira Filho on 2015-03-06: Fixed failing test.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-06:

#

FAILED: Continuous integration, rev:406
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/770/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/73
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1680/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/698/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1678/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/556/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/816
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/816/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/770/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-03-06

407. By Renato Araujo Oliveira Filho on 2015-03-06: Update unit tests.
408. By Renato Araujo Oliveira Filho on 2015-03-06: Used capital letters for Google.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-06:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/771/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Bill Filler (bfiller) wrote on 2015-03-09:

#

2 things need to be fixed:

1) I discussed with Olga about the "ME" avatar. Since we don't have a good translation story, for now we should switch this to use a label instead. The label should say "My phone number:" with the phone number listed to the right of it

2) We need to check if the SIM is locked and display a message to the user, similar to how dialer and messaging-app do it. They display a dialog with a message and a link to unlock. We should do the same thing when the user clicks "Import contacts from SIM card" on the settings or empty list page. Currently we just show the message "SIM card is empty" which is misleading.

review: Needs Fixing

Revision history for this message

Renato Araujo Oliveira Filho (renatofilho) wrote on 2015-03-09:

#

> 2 things need to be fixed:
>
> 1) I discussed with Olga about the "ME" avatar. Since we don't have a good
> translation story, for now we should switch this to use a label instead. The
> label should say "My phone number:" with the phone number listed to the right
> of it
What should be appear when I have more then one sim? Should I show different entries for each SIM? Or show a phone number list in the same entry?

>
> 2) We need to check if the SIM is locked and display a message to the user,
> similar to how dialer and messaging-app do it. They display a dialog with a
> message and a link to unlock. We should do the same thing when the user clicks
> "Import contacts from SIM card" on the settings or empty list page. Currently
> we just show the message "SIM card is empty" which is misleading.

What should be the behavior if only one of the SIM card is blocked? Should I show the contacts for the unlocked ones? Or should I show the message to unlock the SIM?

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-03-10

409. By Renato Araujo Oliveira Filho on 2015-03-10: Replaced "me" card with a item with the label "My phone number"

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-10:

#

FAILED: Continuous integration, rev:409
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/773/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/76
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1703/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/714/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1701/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/569/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/834
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/834/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/773/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Bill Filler (bfiller) wrote on 2015-03-11:

#

> > 2 things need to be fixed:
> >
> > 1) I discussed with Olga about the "ME" avatar. Since we don't have a good
> > translation story, for now we should switch this to use a label instead. The
> > label should say "My phone number:" with the phone number listed to the
> right
> > of it
> What should be appear when I have more then one sim? Should I show different
> entries for each SIM? Or show a phone number list in the same entry?

I would show multiple entries if there are more than one SIM like:
My phone number (SIM1): xxx-xxx-xxx-xxx
My phone number (SIM2): xxx-xxx-xxx-xxx-

If only one sim, then don't show the SIM1 label but just:
My phone number: xxx-xxx-xxx

>
> >
> > 2) We need to check if the SIM is locked and display a message to the user,
> > similar to how dialer and messaging-app do it. They display a dialog with a
> > message and a link to unlock. We should do the same thing when the user
> clicks
> > "Import contacts from SIM card" on the settings or empty list page.
> Currently
> > we just show the message "SIM card is empty" which is misleading.
>
> What should be the behavior if only one of the SIM card is blocked? Should I
> show the contacts for the unlocked ones? Or should I show the message to
> unlock the SIM?

You should show the unlocked ones and also show a message indicating that one of the sims is locked.

Revision history for this message

Bill Filler (bfiller) wrote on 2015-03-11:

#

also make sure to add the new strings to the pot file

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-03-16

410. By Renato Araujo Oliveira Filho on 2015-03-16: Display network name for each SIM card.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-16:

#

FAILED: Continuous integration, rev:410
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/779/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/82
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1792/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/727
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1790/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/584
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/856
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/856/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/779/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-03-16

411. By Renato Araujo Oliveira Filho on 2015-03-16: Show information about locked sims.
412. By Renato Araujo Oliveira Filho on 2015-03-16: Use sim card labels in import page .
413. By Renato Araujo Oliveira Filho on 2015-03-16: Call sim card unlock page instead of open system settings when hitting unlock button.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-16:

#

FAILED: Continuous integration, rev:411
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/780/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/83
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1796/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/729
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1794/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/585
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/859
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/859/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/780/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-16:

#

FAILED: Continuous integration, rev:413
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/781/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/84
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1797/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/731/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1795/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/861/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/781/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-03-16

414. By Renato Araujo Oliveira Filho on 2015-03-16: Added dbus as build dep.
415. By Renato Araujo Oliveira Filho on 2015-03-16: Fixed clenup function for contact list view test.
416. By Renato Araujo Oliveira Filho on 2015-03-16: Show loding message while unlocking a SIM card.
417. By Renato Araujo Oliveira Filho on 2015-03-16: Trunk Merged.
418. By Renato Araujo Oliveira Filho on 2015-03-16: Updated pot file.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-16:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/782/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-16:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/783/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-03-16

419. By Renato Araujo Oliveira Filho on 2015-03-16: Does not show loading message if all sim cards are locked.
420. By Renato Araujo Oliveira Filho on 2015-03-16: Fixed "loading..." message visibility.

Revision history for this message

Renato Araujo Oliveira Filho (renatofilho) wrote on 2015-03-16:

#

Are there any related MPs required for this MP to build/function as expected? NO

Is your branch in sync with latest trunk? YES

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator? YES

Did you successfully run all tests found in your component's Test Plan on device or emulator? YES

If you changed the UI, was the change specified/approved by design? YES

If you changed UI labels, did you update the pot file? YES

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP? NO

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-17:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/784/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-03-17

421. By Renato Araujo Oliveira Filho on 2015-03-17: Show "Unlocking.." message after the sim card be unlocked and "PhoneBook" interface is unavailable.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-17:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/785/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-03-17

422. By Renato Araujo Oliveira Filho on 2015-03-17: Disable "Import from sim" option if no sim is present.
423. By Renato Araujo Oliveira Filho on 2015-03-17: Disable "import from sim" button on contact list if no sim is present.
424. By Renato Araujo Oliveira Filho on 2015-03-17: added missing dep.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-17:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/786/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Tiago Salem Herrmann (tiagosh) on 2015-03-18:

#

review: Needs Information

Revision history for this message

Renato Araujo Oliveira Filho (renatofilho) on 2015-03-18:

#

lp://staging/~renatofilho/address-book-app/sim-card-import updated on 2015-03-18

425. By Renato Araujo Oliveira Filho on 2015-03-18: Use the temporary path returned by Qt to store the sim card import contacts.
Make sure that the imported contacts temporary file get deleted by the app.

Revision history for this message

Tiago Salem Herrmann (tiagosh) wrote on 2015-03-18:

#

Looks good to me now.

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-18:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/787/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Timo Jyrinki (timo-jyrinki) wrote on 2015-03-20:

#

Seems approved.

address-book-app

Merge lp://staging/~renatofilho/address-book-app/sim-card-import into lp://staging/address-book-app

Commit message

Description of the change

Preview Diff

Subscribers