address-book-app

Merge lp://staging/~renatofilho/address-book-app/fix-1548783 into lp://staging/address-book-app

  1. fix-1548783
  2. Merge into trunk
Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Arthur Mello
Approved revision: 585
Merged at revision: 582
Proposed branch: lp://staging/~renatofilho/address-book-app/fix-1548783
Merge into: lp://staging/address-book-app
Diff against target: 219 lines (+69/-12)
5 files modified
src/imports/Ubuntu/AddressBook/ContactEditor/ComboButtonAddField.qml (+19/-1)
src/imports/Ubuntu/AddressBook/ContactEditor/ContactDetailNameEditor.qml (+24/-6)
src/imports/Ubuntu/AddressBook/ContactEditor/ContactEditorPage.qml (+16/-2)
src/imports/Ubuntu/Contacts/ContactAvatar.qml (+2/-2)
src/imports/Ubuntu/Contacts/Contacts.js (+8/-1)
To merge this branch: bzr merge lp://staging/~renatofilho/address-book-app/fix-1548783
Reviewer Review Type Date Requested Status
Arthur Mello (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+293809@code.staging.launchpad.net

Commit message

Implemented support for middle-name.

Allow user do add/edit middle name field.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:582
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1129/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/432
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6904
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/5227
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6915
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6915/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/28154

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1129/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~renatofilho/address-book-app/fix-1548783 updated
583. By Renato Araujo Oliveira Filho

Fixed typo.

584. By Renato Araujo Oliveira Filho

Fixed middle name focus.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:584
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1130/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/433
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6906/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/5228/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6917
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6917/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/28155

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1130/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~renatofilho/address-book-app/fix-1548783 updated
585. By Renato Araujo Oliveira Filho

Check for midle name to build avatar color.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:585
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1131/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/434
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6908
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/5231
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6919
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6919/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/28158

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1131/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Arthur Mello (artmello) wrote :

lgtm

review: Approve
lp://staging/~renatofilho/address-book-app/fix-1548783 updated
586. By Renato Araujo Oliveira Filho

Fix typo.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches