address-book-app

Merge lp://staging/~renatofilho/address-book-app/fix-1373517 into lp://staging/address-book-app

fix-1373517
Merge into trunk

Proposed by Renato Araujo Oliveira Filho on 2014-12-11

Status:

Merged

Approved by:

Bill Filler on 2015-01-12

Approved revision:

347

Merged at revision:

355

Proposed branch:

lp://staging/~renatofilho/address-book-app/fix-1373517

Merge into:

lp://staging/address-book-app

Diff against target:

34 lines (+3/-3)

2 files modified

src/imports/ContactEdit/ContactEditor.qml (+2/-2)
src/imports/ContactList/ContactListPage.qml (+1/-1)

To merge this branch:

bzr merge lp://staging/~renatofilho/address-book-app/fix-1373517

Related bugs:

Bug #1373494: [phone-app]+[address-book] + [messaging-app] Remove "X" when creating a new contact/editing a contact	Medium	Fix Released
Bug #1373517: [sdk] invoked "search" in apps should display "<" for BACK and not "X"	Medium	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Needs Fixing on 2015-01-09
Bill Filler (community)		2014-12-11	Needs Fixing on 2015-01-09
Review via email: mp+244489@code.staging.launchpad.net

Commit message

Replaced "X" (close icon) to "<" (back icon) on application header.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-12-12:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/712/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Renato Araujo Oliveira Filho (renatofilho) wrote on 2014-12-17:

Are there any related MPs required for this MP to build/function as expected? NO

Is your branch in sync with latest trunk? YES

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator? YES

Did you successfully run all tests found in your component's Test Plan on device or emulator? YES

If you changed the UI, was the change specified/approved by design? YES

If you changed UI labels, did you update the pot file? No label changed

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP? no packaging changed

lp://staging/~renatofilho/address-book-app/fix-1373517 updated on 2014-12-17

346. By Renato Araujo Oliveira Filho on 2014-12-17: Trunk merged.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-12-17:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/718/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Bill Filler (bfiller) wrote on 2015-01-09:

This only partially fixes the bug https://bugs.launchpad.net/address-book-app/+bug/1373494
We also need to change the header title to "New Contact" or "Edit" depending on which mode you are in. See the bug description.

review: Needs Fixing

Revision history for this message

Renato Araujo Oliveira Filho (renatofilho) wrote on 2015-01-09:

> This only partially fixes the bug https://bugs.launchpad.net/address-book-
> app/+bug/1373494
> We also need to change the header title to "New Contact" or "Edit" depending
> on which mode you are in. See the bug description.

Fixed messaging app: https://code.launchpad.net/~renatofilho/messaging-app/fix-1367906/+merge/246004