Merge lp://staging/~renamer-developers/renamer/improve-tv-filename-parser into lp://staging/renamer
Proposed by
Jonathan Jacobs
| Status: | Merged | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Approved by: | Tristan Seligmann | ||||||||
| Approved revision: | 89 | ||||||||
| Merged at revision: | 86 | ||||||||
| Proposed branch: | lp://staging/~renamer-developers/renamer/improve-tv-filename-parser | ||||||||
| Merge into: | lp://staging/renamer | ||||||||
| Diff against target: |
399 lines (+221/-99) 4 files modified
DEPS (+1/-1) renamer/plugins/tv.py (+116/-70) renamer/test/test_tvrage.py (+75/-28) scripts/generate_compiled_grammars (+29/-0) |
||||||||
| To merge this branch: | bzr merge lp://staging/~renamer-developers/renamer/improve-tv-filename-parser | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tristan Seligmann | Approve | ||
|
Review via email:
|
|||
Description of the change
Replace PyParsing with PyMeta and implement metadata overrides for the "tvrage" command.
I'm wondering if I should put the grammar in a separate file and commit the result of the "generate_parser" script to the repo, the advantage would be improved import times.
To post a comment you must log in.
Revision history for this message
| Tristan Seligmann (mithrandi) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
