Merge lp://staging/~rbanffy/maas/bug-1337874 into lp://staging/~maas-committers/maas/trunk

Proposed by Ricardo Bánffy
Status: Merged
Approved by: Ricardo Bánffy
Approved revision: no longer in the source branch.
Merged at revision: 3759
Proposed branch: lp://staging/~rbanffy/maas/bug-1337874
Merge into: lp://staging/~maas-committers/maas/trunk
Diff against target: 216 lines (+158/-0)
3 files modified
src/metadataserver/models/commissioningscript.py (+48/-0)
src/metadataserver/models/tests/ip_link_results.txt (+18/-0)
src/metadataserver/models/tests/test_noderesults.py (+92/-0)
To merge this branch: bzr merge lp://staging/~rbanffy/maas/bug-1337874
Reviewer Review Type Date Requested Status
Blake Rouse (community) Approve
Review via email: mp+254779@code.staging.launchpad.net

Commit message

Update node network interface information during commissioning.

Description of the change

Added a new step in the commissioning process that uses `ip link` to gather the MAC addresses of interfaces currently connected to the node and update the node information according to that new information.

To post a comment you must log in.
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Looks close. Just a few comments that should be addressed.

review: Needs Fixing
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Little better. Still wonder why my suggestion was not fully implemented.

review: Needs Information
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Looks good. This will be so nice being fixed, always been a bug that people wanted fixed.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.