Software Updater

Merge lp://staging/~rbalint/update-manager/remove-autoremovable-kernels into lp://staging/update-manager

remove-autoremovable-kernels
Merge into main

Proposed by Balint Reczey on 2018-03-18

Status:	Merged
Merged at revision:	2810
Proposed branch:	lp://staging/~rbalint/update-manager/remove-autoremovable-kernels
Merge into:	lp://staging/update-manager
Diff against target:	277 lines (+76/-23) 4 files modified UpdateManager/Core/MyCache.py (+16/-0) UpdateManager/Core/UpdateList.py (+38/-20) UpdateManager/UpdatesAvailable.py (+15/-3) debian/changelog (+7/-0)
To merge this branch:	bzr merge lp://staging/~rbalint/update-manager/remove-autoremovable-kernels
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Julian Andres Klode	2018-03-18	Approve on 2018-03-21
Brian Murray	2018-03-19	Pending
Łukasz Zemczak	2018-03-18	Pending
Review via email: mp+341599@code.staging.launchpad.net

Revision history for this message

Julian Andres Klode (juliank) wrote on 2018-03-20:

joining the regular expressions with | might fail in case they themselves contain | (or one of them is invalid).

review: Needs Fixing

Revision history for this message

Balint Reczey (rbalint) wrote on 2018-03-20:

> joining the regular expressions with | might fail in case they themselves
> contain | (or one of them is invalid).

Any of them being invalid would be either an apt bug or an error in system configuration which we can't protect against here.
Having | without parentheses in the APT::VersionedKernelPackages regexps also sounds broken in itself that would make it an apt bug again.
Do you think this code would break on non-buggy APT::VersionedKernelPackages regexps?
I can add parentheses like (^...)|(^...) but that does not seem to be needed.

I'd like to avoid multiple matching to keep matching fast.

Revision history for this message

Balint Reczey (rbalint) wrote on 2018-03-21:

Moreover apt regexps like "foo|.*-bar" would break detecting the current running kernel's packages, too.

Revision history for this message

Julian Andres Klode (juliank) wrote on 2018-03-21:

Yes, you're right, | without () would not work correctly anyway.

review: Approve