Merge lp://staging/~rbalint/update-manager/lp-1795898-lp-1790670-cosmic into lp://staging/update-manager

Proposed by Balint Reczey
Status: Merged
Merged at revision: 2843
Proposed branch: lp://staging/~rbalint/update-manager/lp-1795898-lp-1790670-cosmic
Merge into: lp://staging/update-manager
Diff against target: 176 lines (+89/-31)
5 files modified
UpdateManager/backend/InstallBackendAptdaemon.py (+7/-2)
UpdateManager/backend/__init__.py (+26/-6)
debian/changelog (+11/-0)
tests/test_backend_error.py (+45/-0)
tests/test_update_error.py (+0/-23)
To merge this branch: bzr merge lp://staging/~rbalint/update-manager/lp-1795898-lp-1790670-cosmic
Reviewer Review Type Date Requested Status
Julian Andres Klode Approve
Brian Murray Pending
alex Pending
Ubuntu Core Development Team Pending
Review via email: mp+356105@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

I've just a couple of minor in-line comments, otherwise this looks good to me.

Revision history for this message
Balint Reczey (rbalint) :
Revision history for this message
Balint Reczey (rbalint) wrote :

Now the tests are also passing.

Revision history for this message
Julian Andres Klode (juliank) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: