Merge ~rbalint/ubuntu/+source/systemd:ubuntu-focal-lp1870410 into ~ubuntu-core-dev/ubuntu/+source/systemd:ubuntu-focal

Proposed by Balint Reczey
Status: Merged
Merged at revision: 4c48893eb04b01a2ec62d2d2823a79a9f5cb2b80
Proposed branch: ~rbalint/ubuntu/+source/systemd:ubuntu-focal-lp1870410
Merge into: ~ubuntu-core-dev/ubuntu/+source/systemd:ubuntu-focal
Diff against target: 102 lines (+88/-0)
2 files modified
debian/patches/dhcp-Allow-setting-request-options-again.patch (+87/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Dimitri John Ledkov Pending
Review via email: mp+382713@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Balint Reczey (rbalint) wrote :

It fixed wifi on my rpi2 with external wifi dongle and is unlikely to cause regressions.

I'm looking into not calling link_configure multiple times or at least skipping bigger parts of the configuration before forwarding this upstream.

Revision history for this message
Dan Streetman (ddstreet) wrote :

It's possible it's being initialized multiple times because the Ubuntu systemd reverts this (and some related) patch:
https://github.com/systemd/systemd/commit/bd08ce56156751d58584a44e766ef61340cdae2d

The revert commit:
https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?h=ubuntu-focal&id=70e93c2a05f0f7435614f8d52944d726601e319c

I haven't looked at netplan's autopkgtest, but it seems to me like that should be fixed, instead of carrying a problematic revert from upstream.

Revision history for this message
Balint Reczey (rbalint) wrote :

@ddstreet yes, I dropped the reverts but systemd autopkgtest networkd-test.py fails without them now, too. I'm looking into the problem, but this very small change seems better for focal because it comes with lower risk.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches