Merge lp://staging/~rbalint/merge-o-matic/merge-o-matic-comment into lp://staging/merge-o-matic

Proposed by Balint Reczey
Status: Merged
Merged at revision: 295
Proposed branch: lp://staging/~rbalint/merge-o-matic/merge-o-matic-comment
Merge into: lp://staging/merge-o-matic
Diff against target: 108 lines (+19/-11)
4 files modified
cron.daily (+10/-8)
manual-status.py (+3/-1)
merge-status.py (+3/-1)
pack-archive.sh (+3/-1)
To merge this branch: bzr merge lp://staging/~rbalint/merge-o-matic/merge-o-matic-comment
Reviewer Review Type Date Requested Status
Ubuntu Core Development Team Pending
Review via email: mp+323327@code.staging.launchpad.net

Description of the change

* Show empty comment textbox in white on merge status
  It is not nice but it reflects that it is painfully empty. Fill it with
  a BTS bug number in which the delta is forwarded! :-)
  Closes: LP: #1686640

* Consolidate hard-coded /srv/patches.ubuntu.com paths

I need to test the last <%..%> replacements, but otherwise this seems to be working.
If someone could test those quickly that would be nice.

To post a comment you must log in.
295. By Balint Reczey

Show empty comment textbox in white on merge status

It is not nice but it reflects that it is painfully empty. Fill it with
a BTS bug number in which the delta is forwarded! :-)

Closes: LP: #1686640

296. By Balint Reczey

Consolidate hard-coded /srv/patches.ubuntu.com paths

Revision history for this message
Brian Murray (brian-murray) wrote :

We tested this on merges.ubuntu.com and discovered that the indent of the req.write() ended up causing and error.

https://merges.ubuntu.com/main-new.html

Revision history for this message
Balint Reczey (rbalint) :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: