Merge ~rayveldkamp/qa-regression-testing:tests/dockerio-cve-2021-41092 into qa-regression-testing:master

On Thu, Nov 04, 2021 at 05:40:46AM -0000, Ray Veldkamp wrote:
> +def update_hosts_file(entry):
> + '''Add an entry to the END of the system /etc/hosts file. No validation is performed on the entry being inserted.'''
> + subprocess.call(['sed', '-i', '$ a {0}'.format(entry), "/etc/hosts"])

Most of this looks good to me, but I'm a bit surprised to shell out to sed
to add a new line to a file; it is impressive it fits in one line, though
:)

Thanks for the testlib suggestion, I've updated to use this and removed the shell out function and call in setup().

Thanks, this looks great. I touched up a couple of things and merged the branch:

  - QRT-Packages is space seperated not comma
  - python[23] in xenial (and older) don't support ssl.PROTOCOL_TLS, so fall back to PROTOCOL_TLSv1_2 in that situation

Unrelated to your merge, I also eliminated the deprecation warning from the script using unittest.assertRegexpMatches by replacing it with assertRegex().

I like the quick and dirty https server. testlib_http-test-server.py exists but isn't as amenable to simple usages like this; it'd be a nice improvement to figure out an abstraction to make it possible to use in other tests.