Ubuntu Rest Scopes

Merge lp://staging/~ralsina/ubuntu-rest-scopes/short-digits-vulgarian into lp://staging/ubuntu-rest-scopes

short-digits-vulgarian
Merge into trunk

Proposed by Roberto Alsina on 2016-03-07

Status:	Merged
Approved by:	Roberto Alsina on 2016-03-07
Approved revision:	508
Merged at revision:	507
Proposed branch:	lp://staging/~ralsina/ubuntu-rest-scopes/short-digits-vulgarian
Merge into:	lp://staging/ubuntu-rest-scopes
Diff against target:	25 lines (+3/-2) 2 files modified src/scopes/tests/test_weatherchannel.py (+1/-1) src/scopes/weatherchannel.py (+2/-1)
To merge this branch:	bzr merge lp://staging/~ralsina/ubuntu-rest-scopes/short-digits-vulgarian
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Daniel Manrique (community)		2016-03-07	Approve on 2016-03-07
Review via email: mp+288311@code.staging.launchpad.net

Commit message

Limit lat/long to 2 decimals in search_location to avoid TWC API error.

Description of the change

So, TWC doesn't like too many decimals on the location query. Oops, I guess.

Limiting to 2 decimals, which gives a precision of ~15 meters on each direction, so it should be enough to know on which city you are in most cases.

Revision history for this message

Daniel Manrique (roadmr) wrote on 2016-03-07:

+1, short and sweet.

review: Approve

Revision history for this message

Ubuntu One Auto Pilot (otto-pilot) wrote on 2016-03-07:

The attempt to merge lp:~ralsina/ubuntu-rest-scopes/short-digits-vulgarian into lp:ubuntu-rest-scopes failed. Below is the output from the failed tests.

......................................................................................................................................................................................................................................F.............................................................................................................................
======================================================================
FAIL: test__get_location_key_simple (src.scopes.tests.test_weatherchannel.TWCInterfaceTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/mnt/tarmac/cache/ubuntu-rest-scopes/trunk/src/scopes/tests/test_weatherchannel.py", line 767, in test__get_location_key_simple
    mock.assert_called_with(loc_uri)
  File "/usr/lib/python2.7/dist-packages/mock.py", line 835, in assert_called_with
    raise AssertionError(msg)
AssertionError: Expected call: mock('https://api.weather.com/v2/location?geocode=1.0,1.0&language=en-GB&format=json&apiKey=bar')
Actual call: mock('https://api.weather.com/v2/location?geocode=1.00,1.00&language=en-GB&format=json&apiKey=bar')