Merge lp://staging/~ralsina/ubuntu-push/form-in-example-app into lp://staging/ubuntu-push/automatic

Proposed by Roberto Alsina
Status: Merged
Approved by: Roberto Alsina
Approved revision: 151
Merged at revision: 335
Proposed branch: lp://staging/~ralsina/ubuntu-push/form-in-example-app
Merge into: lp://staging/ubuntu-push/automatic
Diff against target: 409 lines (+232/-54)
7 files modified
debian/changelog (+7/-0)
docs/example-client/components/ChatClient.qml (+2/-2)
docs/example-server/app.js (+31/-13)
docs/example-server/config/config.js (+1/-1)
docs/example-server/index.html (+2/-0)
docs/example-server/notify-form.html (+61/-6)
docs/example-server/test/app_test.js (+128/-32)
To merge this branch: bzr merge lp://staging/~ralsina/ubuntu-push/form-in-example-app
Reviewer Review Type Date Requested Status
Samuele Pedroni Approve
Review via email: mp+234862@code.staging.launchpad.net

Commit message

Added a friendly form to the example server app

Description of the change

Adds a friendly form to the example server app.

You can see it in action at http://direct.ralsina.me:8001 and see what it does using the hello app from the store.

To post a comment you must log in.
140. By Roberto Alsina

was using wrong nick in popup, removed debug log

141. By Roberto Alsina

log data

142. By Roberto Alsina

use message + body

143. By Roberto Alsina

use message + body in client app too

144. By Roberto Alsina

wrong name in field

145. By Roberto Alsina

start noisier

146. By Roberto Alsina

use lowercase nicks, fix label in form

147. By Roberto Alsina

fix existing tests

148. By Roberto Alsina

remove debug log

149. By Roberto Alsina

fix existing tests

150. By Roberto Alsina

remove log

Revision history for this message
Samuele Pedroni (pedronis) wrote :

bit confused by showError code

Revision history for this message
Roberto Alsina (ralsina) wrote :

Replied inline

Revision history for this message
Samuele Pedroni (pedronis) :
review: Approve
151. By Roberto Alsina

simpler showError

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches