Ubuntu Push QML

Merge lp://staging/~ralsina/ubuntu-push-qml/unpack-tags into lp://staging/ubuntu-push-qml/rtm

  1. unpack-tags
  2. Merge into rtm
Proposed by Roberto Alsina
Status: Merged
Approved by: Roberto Alsina
Approved revision: 12
Merged at revision: 10
Proposed branch: lp://staging/~ralsina/ubuntu-push-qml/unpack-tags
Merge into: lp://staging/ubuntu-push-qml/rtm
Diff against target: 15 lines (+4/-1)
1 file modified
src/Ubuntu/PushNotifications/pushclient.cpp (+4/-1)
To merge this branch: bzr merge lp://staging/~ralsina/ubuntu-push-qml/unpack-tags
Reviewer Review Type Date Requested Status
Roberto Alsina (community) Approve
Review via email: mp+240574@code.staging.launchpad.net

Commit message

Expand tags before passing them to clearPersistent

Description of the change

Expand tags before passing them to clearPersistent (bug #1384855)

To test:

Install hello app.
Edit main.qml and change

        Component.onCompleted: {
            notificationsChanged.connect(messageList.handle_notifications)
            error.connect(messageList.handle_error)
        }

to

        Component.onCompleted: {
            notificationsChanged.connect(messageList.handle_notifications)
            error.connect(messageList.handle_error)
            pushClient.clearPersistent([])
        }

Start the app, make sure it doesn't crash push-client.

To post a comment you must log in.
Revision history for this message
Roberto Alsina (ralsina) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches